Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounty: enable accept / reject worker for owner #2005

Merged
merged 1 commit into from Aug 15, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Aug 15, 2018

Description

This is to ensure that the accept / reject options appear on the screen when the funder is logged in on his permission-ed bounty

To test :

  • Create Permissioned bounty as X -> Start work as another user Y

Y should not see any options on the work applied section
X should see 2 buttons Approve & Reject on the work applied section

Tested it out locally but needs one more round of testing on stage

x1

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Refers/Fixes

#1947

@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #2005 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2005   +/-   ##
=======================================
  Coverage   25.37%   25.37%           
=======================================
  Files         132      132           
  Lines       10890    10890           
  Branches     1456     1456           
=======================================
  Hits         2763     2763           
  Misses       8051     8051           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739352f...476a03b. Read the comment docs.

@mbeacom
Copy link
Contributor

mbeacom commented Aug 15, 2018

This is on staging - 👀

Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SaptakS SaptakS merged commit f6ed38f into gitcoinco:master Aug 15, 2018
@thelostone-mc thelostone-mc deleted the bounty branch August 16, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants