Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metamask gas price preview #205

Merged
merged 11 commits into from Jan 4, 2018

Conversation

Projects
None yet
4 participants
@owocki
Copy link
Member

commented Jan 2, 2018

what

https://twitter.com/owocki/status/948304738306605056

still TODO

integrations

  • do the 'new bounty' form. (i've already done the claiming, clawback, and process page)
  • do the 'tips' form.

functionality

  • do an estimate of how much ETH / USD it will cost on the page.
  • allow user to update gas price and see an estimate of confirmation times and price on the page.
  • see a warning when network conditions are clogged.

owocki added some commits Jan 2, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2018

another idea: I think bringing in a a simplified description (immediate info needed to take action) of the gas concept (from the github page) into a tooltip on the Claim Funds page is another way to solve this. It will help keep all of the information in context to the experience.

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2018

hat tip @PixelantDesign

owocki added some commits Jan 3, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2018

just pushed some changes
screen recording 2018-01-02 at 11 49 pm

owocki added some commits Jan 3, 2018

@mkosowsk

This comment has been minimized.

Copy link

commented Jan 4, 2018

I have submitted funding for this issue with a

Gas Limit: 649619
Gas Price: 0.000000021 Ether (21 Gwei)

The gas limit I used from what Gitcoin recommended and found a suitable gas price via https://ethgasstation.info/predictionTable.php (I increased the Gas Price from 10 -> 21 Gwei because it was taking too long)

Looking forward to seeing it fund 👍🏻👍🏻👍🏻

@mkosowsk

This comment has been minimized.

Copy link

commented Jan 4, 2018

Hmm I may have borked this up.

This was the initial transaction that I used to try to fund this issue:

https://etherscan.io/tx/0xa43401b3701cc6b54b8bff27bef2ae13a84441ac09ab84287c7dfdf9d645d55b

But when it was taking too long I bumped up the gas price via MetaMask. It looks like that created a new tx?

https://etherscan.io/tx/0x85a6f56096f34d8d0443d49790c13f810aeb5cb9287f36f3bf50dd87b0f54c3e

Not sure if this issue will be funded properly now 😓

@gitcoinbot

This comment has been minimized.

Copy link
Member

commented Jan 4, 2018

This issue now has a funding of 0.05 ETH (47.32 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $13726.15 more Funded OSS Work Available at: https://gitcoin.co/explorer
@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2018

thanks for the funding @mkosowsk!

i think im actually pretty close to merging this... let me know what else you think should be in order for the scope of this issue

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2018

this could be something cool to work in gitcoinco/skunkworks#34

owocki added some commits Jan 4, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2018

just added a nice little page to show gas data :)
screencapture-localhost-8080-gas-1515075087776

@owocki owocki merged commit 39e7ed6 into master Jan 4, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@mkosowsk

This comment has been minimized.

Copy link

commented Jan 4, 2018

LGTM! Feel free to claim issue at your earliest convenience.

This should help clear a lot of user confusion and provide a great boost to the UX 👍🏻

@gitcoinbot

This comment has been minimized.

Copy link
Member

commented Jan 4, 2018

The funding of 0.05 ETH (49.83 USD) attached has been claimed by @owocki.

@owocki, please leave a comment to let the funder (@Mitch_Kosowski) and the other parties involved your implementation plan. If you don't leave a comment, the funder may expire your claim at their discretion.

@mkosowsk

This comment has been minimized.

Copy link

commented Jan 4, 2018

Hmm when I try to Accept this claim I am seeing

screen shot 2018-01-04 at 10 21 57 am

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2018

hmm a caching issue i wonder? if you hard refresh (apple shirt R) does it go away?

i just tried busting the cloudfront cache

@mkosowsk

This comment has been minimized.

Copy link

commented Jan 4, 2018

Yep, that was it probably left over cache when I was messing around with things!

Sending it over 👍🏻 thanks for the help

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2018

hmm... i wonder if i need to revisit the cache busting strategy for gitcoin.. i had assumed that busting the cloudfront cache would do the trick... but i guess not

@mkosowsk

This comment has been minimized.

Copy link

commented Jan 4, 2018

Not to keep hammering you, but submitted the claim ~30 minutes and still seeing the blue alert on top of the gitcoin page

screen shot 2018-01-04 at 11 20 43 am

And when I check out the etherscan I see "Sorry, we are unable to locate this Transaction Hash
"

https://etherscan.io/tx/0x73d7d211e330b7bfedd66df6688eeb6fd9596205e8ddc382b6e591a755dc2da2

What generally happens after accepting a claim? I set a gas price of something like 23 Gwei so I think this should probably be sent over pretty quick 🤔

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2018

https://etherscan.io/tx/0x73d7d211e330b7bfedd66df6688eeb6fd9596205e8ddc382b6e591a755dc2da2

damn, looks like this tx is STILL pending. hard to believe it, but considering the gas price is only 5 gwei and the network has been going parabolic.. its also not that surprising.

do you see the tx in metamask? might be worth submitting with a higher gas price value..

screen shot 2018-01-08 at 5 37 00 pm

@vs77bb

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2018

@owocki Is this one still in your hands?

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 17, 2018

looks like the claim finally did go through.. https://etherscan.io/tx/0x73d7d211e330b7bfedd66df6688eeb6fd9596205e8ddc382b6e591a755dc2da2

@mkosowsk could you pay it out?

@mkosowsk

This comment has been minimized.

Copy link

commented Jan 17, 2018

Sure, will visit some time tonight as I'm a bit slammed at work at the moment 👍

@mkosowsk

This comment has been minimized.

Copy link

commented Jan 17, 2018

Took a quick look and saw this, bumped Gas Price to 4 Gwei to get a 10 min confirmation

gitcoin screenshot

But after I click Accept, I see this warning:

after accepting

I have Web3 enabled and looks like I have enough Eth, so not sure where I'm messing up or if this is a bug? 🤔🤔🤔

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 17, 2018

oh shoot.. it looks like you actually already remitted the funds... my bad

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jan 17, 2018

running the DB sync script now

@gitcoinbot

This comment has been minimized.

Copy link
Member

commented Jan 17, 2018

The funding of 0.05 ETH (49.34 USD) attached to this issue has been approved & issued to @owocki.

@mkosowsk

This comment has been minimized.

Copy link

commented Jan 17, 2018

No worries, I can only assume that this means you are getting so much cashflow from Gitcoin that it's hard to keep track 😂

@owocki irl?

scrooge

🤔

ethikz pushed a commit to ethikz/web that referenced this pull request Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.