Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: fix missing background color #2142

Merged
merged 1 commit into from Sep 3, 2018

Conversation

Projects
None yet
3 participants
@thelostone-mc
Copy link
Member

commented Sep 3, 2018

Description

screen shot 2018-09-03 at 9 47 18 am

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Refers/Fixes

Fixes: #2141

@pmaojo thanks for the report :)
I've put out the fix! Feel free to review and give feedback if needed

@mbeacom mbeacom added the in progress label Sep 3, 2018

@thelostone-mc thelostone-mc requested a review from SaptakS Sep 3, 2018

@thelostone-mc thelostone-mc self-assigned this Sep 3, 2018

@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2018

Codecov Report

Merging #2142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2142   +/-   ##
=======================================
  Coverage   27.83%   27.83%           
=======================================
  Files         136      136           
  Lines       11167    11167           
  Branches     1509     1509           
=======================================
  Hits         3108     3108           
  Misses       7949     7949           
  Partials      110      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86ec45...7ee1629. Read the comment docs.

@SaptakS

SaptakS approved these changes Sep 3, 2018

@SaptakS SaptakS merged commit 26875a5 into gitcoinco:master Sep 3, 2018

5 checks passed

codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing d86ec45...7ee1629
Details
codecov/project 27.83% remains the same compared to d86ec45
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@SaptakS SaptakS removed the needs review label Sep 3, 2018

@thelostone-mc thelostone-mc deleted the thelostone-mc:bug/landing branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.