Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: updated markdown #2202

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
4 participants
@thelostone-mc
Copy link
Member

commented Sep 12, 2018

Description

A contributor is expected to provide plan of action before starting work on an permissioned issue.
Occasionaly they use ordered list and when we render this in bot message (which itself is a ordered list), it ends up looking like this

This PR changes the latter to unordered-list

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Testing

screen shot 2018-09-12 at 8 51 43 pm

How it looks on a github comment

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 5 months, 3 weeks from now.
Please review their action plans below:

1) thelostone-mc has applied to start work (Funders only: approve worker | reject worker).

  1. Will first build out the screen.
  2. Implement the already contributed functionality.
  3. Discuss with the team how to send out the message to users.

Learn more on the Gitcoin Issue Details page.

@mbeacom mbeacom added the in progress label Sep 12, 2018

@codecov

This comment has been minimized.

Copy link

commented Sep 12, 2018

Codecov Report

Merging #2202 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2202   +/-   ##
=======================================
  Coverage   27.75%   27.75%           
=======================================
  Files         141      141           
  Lines       11367    11367           
  Branches     1543     1543           
=======================================
  Hits         3155     3155           
  Misses       8102     8102           
  Partials      110      110
Impacted Files Coverage Δ
app/dashboard/notifications.py 16.82% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a1f0c...37ea63d. Read the comment docs.

@thelostone-mc thelostone-mc requested a review from mbeacom Sep 12, 2018

@thelostone-mc thelostone-mc added this to Needs review in September A - Core Team Sep 12, 2018

@thelostone-mc thelostone-mc removed this from Needs review in September A - Core Team Sep 12, 2018

@thelostone-mc thelostone-mc added this to Needs review in Triage Bugs Sep 12, 2018

@vs77bb

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2018

@thelostone-mc This is a simple PR but makes a huge difference visually! Good catch 👍

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:derp branch 2 times, most recently from dc548a4 to d44eec2 Sep 12, 2018

@thelostone-mc thelostone-mc changed the title bot: changed ordered -> unordered list bot: updated co-op ordered list Sep 12, 2018

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:derp branch from d44eec2 to 37ea63d Sep 12, 2018

@thelostone-mc thelostone-mc changed the title bot: updated co-op ordered list bot: updated markdown Sep 12, 2018

@SaptakS
Copy link
Contributor

left a comment

LOL

Triage Bugs automation moved this from Needs review to Reviewer approved Sep 12, 2018

@SaptakS SaptakS merged commit e9c491b into gitcoinco:master Sep 12, 2018

4 of 6 checks passed

codecov/patch 0% of diff hit (target 27.75%)
Details
stickler-ci Code review queued
ci/circleci Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/project 27.75% remains the same compared to 44a1f0c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Triage Bugs automation moved this from Reviewer approved to Done Sep 12, 2018

@SaptakS SaptakS removed the in progress label Sep 12, 2018

@thelostone-mc thelostone-mc deleted the thelostone-mc:derp branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.