Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: Notifications #3221

Merged
merged 129 commits into from Jan 16, 2019

Conversation

@octavioamu
Copy link
Collaborator

commented Dec 14, 2018

Description
Checklist
Affected core subsystem(s)
Refers/Fixes

Refs: #2404 #3083

Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

octavioamu and others added some commits Nov 27, 2018

Mark Beacom
Merge pull request #3083 from usmanmuhd/notifs-backend
[WIP] Changes to backend for notifications

octavioamu added some commits Jan 9, 2019

octavioamu added some commits Jan 9, 2019

@octavioamu octavioamu changed the title Notifications [WIP] DONT MERGE Notifications Jan 9, 2019

app/inbox/signals.py Outdated Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved

octavioamu added some commits Jan 9, 2019

@owocki

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

test notes:

  • start / submit work works really well
  • when i send a new tip to a user, there is no notification
  • when i send a new kudos to a user, there is no notification
@@ -69,12 +77,20 @@ h4,
position: fixed;
top: 0;
left: 0;
/* right: 0; */

This comment has been minimized.

Copy link
@owocki

owocki Jan 14, 2019

Member

dead code; remove?

let numPages = '';
let numNotifications = '';

Vue.mixin({

This comment has been minimized.

Copy link
@owocki

owocki Jan 14, 2019

Member

excited to learn more about Vue -- itd becool to have a brownbag from you hearing how we can leverage Vue more for our codebase!

cc @SaptakS

This comment has been minimized.

Copy link
@octavioamu

octavioamu Jan 15, 2019

Author Collaborator

I believe that explorer and bounty details are great candidates to be in Vue, will facilitate a lot the states changes from the json request.

('new_milestone', 'New Milestone'),
('update_milestone', 'Updated Milestone'),
('new_kudos', 'New Kudos'),
)

This comment has been minimized.

Copy link
@owocki

owocki Jan 14, 2019

Member

@usmanmuhd can you confirm that all of these notification types have been integrated?

This comment has been minimized.

Copy link
@owocki

owocki Jan 14, 2019

Member

for example, i dont see killed_grant listed anywhere else in the codebase

('bounty_removed_by_funder', 'Removed from Bounty by Funder'),
('new_crowdfund', 'New Crowdfund Contribution'),
('new_grant', 'New Grant'),
('update_grant', 'Updated Grant'),

This comment has been minimized.

Copy link
@owocki

owocki Jan 14, 2019

Member

update_grant not implemented either..

can you do a more exhaustive audit of these... we need to know which are implemented and which arent'

This comment has been minimized.

Copy link
@octavioamu

octavioamu Jan 14, 2019

Author Collaborator

Yes I said to @usmanmuhd to do the ones he could do, and we can see later the others. I mean is something we can be gradually implementing I believe.

octavioamu and others added some commits Jan 14, 2019

Merge pull request #3537 from usmanmuhd/inbox-backend
[WIP] Added new notif generation

@thelostone-mc thelostone-mc changed the title [WIP] DONT MERGE Notifications code: Notifications Jan 16, 2019

@SaptakS
Copy link
Contributor

left a comment

LGTM

@SaptakS SaptakS merged commit 15e2a4a into master Jan 16, 2019

4 checks passed

codecov/patch 42.76% of diff hit (target 29.6%)
Details
codecov/project 29.73% (+0.13%) compared to 90bedf5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@gitcoinbot gitcoinbot referenced this pull request Jan 16, 2019
12 of 15 tasks complete
@owocki

This comment has been minimized.

Copy link
Member

commented on app/inbox/signals.py in 8ae2b8a Jan 28, 2019

915c93e

just FYI for next time!

@thelostone-mc thelostone-mc deleted the vue-notifications branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.