Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter switch #4448

Merged
merged 10 commits into from Jun 24, 2019

Conversation

3 participants
@octavioamu
Copy link
Collaborator

commented May 20, 2019

Description

image

Refers/Fixes

#4413

Testing

@octavioamu octavioamu changed the title Newsletter switch [WIP] Newsletter switch May 20, 2019

@octavioamu

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

waiting new forms links
@frankchen07 @PixelantDesign

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #4448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4448   +/-   ##
======================================
  Coverage    30.3%   30.3%           
======================================
  Files         214     214           
  Lines       17142   17142           
  Branches     2319    2319           
======================================
  Hits         5195    5195           
  Misses      11740   11740           
  Partials      207     207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2098f26...02bfe4c. Read the comment docs.

octavioamu added some commits Jun 12, 2019

@octavioamu octavioamu changed the title [WIP] Newsletter switch Newsletter switch Jun 20, 2019

@octavioamu octavioamu requested a review from gitcoinco/engineers Jun 20, 2019

@octavioamu

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 20, 2019

@gitcoinco/engineers Ready to review!!

@danlipert

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

@octavioamu looks good to me - how was it tested?

@thelostone-mc thelostone-mc added this to Review-Pending in PR Review Board Jun 23, 2019

@thelostone-mc

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

^ @danlipert testing it is as simple as clicking on the tab and ensuring the subscribe button open the right form I believe!

cc @octavioamu

@thelostone-mc
Copy link
Member

left a comment

@octavioamu looks like the styling hasn't been applied

Screenshot 2019-06-24 at 6 38 45 PM

Also, it redirects to bad page when I click on subscribe without entering name

http://consensys.us11.list-manage.com/subscribe/post?u=947c9b18fc27e0b00fc2ad055&id=d870d1315e

@octavioamu

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 24, 2019

@thelostone-mc remember always to hard reload the browser to see the changes, here is a video https://embed.vidyard.com/share/1xuruC2LraV2ghEM482m2d?

@octavioamu

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 24, 2019

@thelostone-mc I had added validation

@thelostone-mc
Copy link
Member

left a comment

sweet

@octavioamu octavioamu merged commit 0955aff into master Jun 24, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 2098f26...02bfe4c
Details
codecov/project 30.3% remains the same compared to 2098f26
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

PR Review Board automation moved this from Review-Pending to Done Jun 24, 2019

@thelostone-mc thelostone-mc deleted the newsletter-switch branch Jun 24, 2019

@danlipert

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2019

@thelostone-mc @octavioamu I ask just because the PR description didn't have any testing info - its a good way for us to double check as well as see what assumptions the PR creator is making during testing. Remember to hold off on merging until Aditya and I both review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.