Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displays all tokens in user profile #4597

Conversation

Projects
6 participants
@rafalkowalski
Copy link
Contributor

commented Jun 8, 2019

Description

Adds all tokens to users profile

Refers/Fixes

#4590

Testing

Tests cover the code changes

Reviewers
@danlipert @thelostone-mc

@rafalkowalski rafalkowalski force-pushed the rafalkowalski:I4590/add-missing-crypto-in-profile-page branch from 04dae4f to b091b2c Jun 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 8, 2019

Codecov Report

Merging #4597 into master will decrease coverage by 0.06%.
The diff coverage is 5.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4597      +/-   ##
==========================================
- Coverage   30.12%   30.06%   -0.07%     
==========================================
  Files         210      210              
  Lines       16911    16930      +19     
  Branches     2284     2290       +6     
==========================================
- Hits         5095     5090       -5     
- Misses      11619    11643      +24     
  Partials      197      197
Impacted Files Coverage Δ
app/dashboard/models.py 56.02% <5.26%> (-0.61%) ⬇️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17efb5...b091b2c. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 8, 2019

Codecov Report

Merging #4597 into master will decrease coverage by 0.02%.
The diff coverage is 5.26%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4597      +/-   ##
=========================================
- Coverage   30.33%   30.3%   -0.03%     
=========================================
  Files         214     214              
  Lines       17122   17141      +19     
  Branches     2313    2319       +6     
=========================================
+ Hits         5194    5195       +1     
- Misses      11721   11739      +18     
  Partials      207     207
Impacted Files Coverage Δ
app/dashboard/models.py 56.25% <5.26%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653d229...cf8c5ef. Read the comment docs.

@rafalkowalski rafalkowalski force-pushed the rafalkowalski:I4590/add-missing-crypto-in-profile-page branch from b091b2c to 22120d9 Jun 8, 2019

@PixelantDesign PixelantDesign requested a review from danlipert Jun 9, 2019

@thelostone-mc
Copy link
Member

left a comment

codewise lgtm

@PixelantDesign

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

lets merge? @thelostone-mc

@PixelantDesign PixelantDesign added this to In progress in Robot Board via automation Jun 11, 2019

@octavioamu octavioamu requested a review from gitcoinco/engineers Jun 11, 2019

@thelostone-mc

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@PixelantDesign -> we need approval from more than 1 reviewer before merging in PR

Robot Board automation moved this from In progress to In Review/PR Review Jun 12, 2019

@danlipert
Copy link
Collaborator

left a comment

Looks nice! Just a few fixes and questions

Show resolved Hide resolved app/dashboard/models.py Outdated
Show resolved Hide resolved app/dashboard/models.py
Show resolved Hide resolved app/dashboard/templates/profiles/profile.html Outdated
Show resolved Hide resolved app/dashboard/tests/test_dashboard_models.py Outdated
Show resolved Hide resolved app/dashboard/tests/test_dashboard_models.py

@rafalkowalski rafalkowalski force-pushed the rafalkowalski:I4590/add-missing-crypto-in-profile-page branch from 22120d9 to a874c52 Jun 12, 2019

@thelostone-mc thelostone-mc requested a review from danlipert Jun 14, 2019

@danlipert
Copy link
Collaborator

left a comment

Thanks, looks great! @thelostone-mc @octavioamu please review 👍

Robot Board automation moved this from In Review/PR Review to Blocked Jun 19, 2019

@danlipert

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

@rafalkowalski can you squash and rebase on master? Thanks!

@thelostone-mc thelostone-mc requested a review from octavioamu Jun 19, 2019

@rafalkowalski rafalkowalski force-pushed the rafalkowalski:I4590/add-missing-crypto-in-profile-page branch from f2f84d7 to 5022413 Jun 19, 2019

Robot Board automation moved this from Blocked to In Review/PR Review Jun 19, 2019

@rafalkowalski rafalkowalski force-pushed the rafalkowalski:I4590/add-missing-crypto-in-profile-page branch from 5022413 to 4dae3a9 Jun 19, 2019

@rafalkowalski

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@danlipert I've rebased code with master

Robot Board automation moved this from In Review/PR Review to Blocked Jun 19, 2019

@thelostone-mc
Copy link
Member

left a comment

yay

@danlipert

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

@octavioamu please review, thanks!

@octavioamu
Copy link
Collaborator

left a comment

Left a comment about not closing html tag. After that LGTM

Show resolved Hide resolved app/dashboard/templates/profiles/profile.html Outdated
Show resolved Hide resolved app/dashboard/templates/profiles/profile.html

Robot Board automation moved this from Blocked to In Review/PR Review Jun 21, 2019

@rafalkowalski rafalkowalski dismissed stale reviews from thelostone-mc and danlipert via 4f4917c Jun 21, 2019

@rafalkowalski rafalkowalski force-pushed the rafalkowalski:I4590/add-missing-crypto-in-profile-page branch from 4dae3a9 to 4f4917c Jun 21, 2019

Robot Board automation moved this from In Review/PR Review to Blocked Jun 21, 2019

@octavioamu
Copy link
Collaborator

left a comment

Great, LGTM

@thelostone-mc thelostone-mc merged commit 61393af into gitcoinco:master Jun 22, 2019

1 of 3 checks passed

codecov/patch 5.26% of diff hit (target 30.33%)
Details
codecov/project 30.3% (-0.03%) compared to 2f79fd4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Robot Board automation moved this from Blocked to Done Jun 22, 2019

@owocki

This comment has been minimized.

Copy link
Member

commented on app/dashboard/models.py in 4f4917c Jul 11, 2019

not all tokens are base 18. check token.decimals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.