Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: override org name + photo #4646

Merged
merged 6 commits into from Jun 24, 2019

Conversation

3 participants
@thelostone-mc
Copy link
Member

commented Jun 17, 2019

Description

  • updated models Profile & Bounty -> override name + url
  • added provision in admin to enable admin overrides
  • updated template to use newly added property
  • update existing prop to use override name + url

Steps

In this example -> assume we'd be updating metamask name to xyz and their logo

Update Profile (/profile/xyz)
  • head over to admin profile section and click on profile you need to update
  • update Admin override name to the new name (xyz)
  • upload photo Admin override avatar:

^ This would ensure that the profile page of the org shows the overridden name + photo

Update Bounty (only for bounty + hackathon)

This is the tricky part.

  • You'll have to select all the bounties created by the org
  • For each bounty -> navigate to the bounty admin
  • update Admin override org name to the new name (xyz)
  • upload photo Admin override org logo

^ This would ensure that the bounty details page of the org shows the overridden name + photo
These are temp fixes which will be removed out once orgs is built out as a feature

note: do not use this for non-hackathon bounties ( especially name change as the filters extra map to the actual Github name)

Demo: Check HERE

@codecov

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #4646 into master will increase coverage by <.01%.
The diff coverage is 22.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4646      +/-   ##
==========================================
+ Coverage   30.06%   30.06%   +<.01%     
==========================================
  Files         213      213              
  Lines       17098    17113      +15     
  Branches     2311     2317       +6     
==========================================
+ Hits         5140     5145       +5     
- Misses      11758    11766       +8     
- Partials      200      202       +2
Impacted Files Coverage Δ
app/dashboard/admin.py 65.55% <0%> (-0.37%) ⬇️
app/dashboard/models.py 56.46% <26.31%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb2486...131b268. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #4646 into master will decrease coverage by <.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4646      +/-   ##
==========================================
- Coverage   30.43%   30.43%   -0.01%     
==========================================
  Files         216      216              
  Lines       17188    17210      +22     
  Branches     2322     2329       +7     
==========================================
+ Hits         5232     5238       +6     
- Misses      11749    11764      +15     
- Partials      207      208       +1
Impacted Files Coverage Δ
app/dashboard/helpers.py 13.96% <ø> (ø) ⬆️
app/dashboard/views.py 14.36% <0%> (-0.05%) ⬇️
app/dashboard/admin.py 65.55% <0%> (-0.37%) ⬇️
app/dashboard/models.py 55.68% <27.27%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3649843...17503e5. Read the comment docs.

feat: override org name + photo
- updated models Profile & Bounty -> override name + url
- added provision in admin to enable admin overrides
- updated template to use newly added property
- update existing prop to use override name + url

@thelostone-mc thelostone-mc force-pushed the override branch from 131b268 to 9059bce Jun 18, 2019

@thelostone-mc thelostone-mc requested review from alexvotofuture and gitcoinco/engineers Jun 18, 2019

@thelostone-mc thelostone-mc marked this pull request as ready for review Jun 18, 2019

@danlipert

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

Very nice! I think the URL issue is okay since its based on their github name, so its not "wrong" per se, just not perfect - and changing it would be a big headache. @vs77bb @alexvotofuture what do y'all think?

@danlipert
Copy link
Collaborator

left a comment

Looks good, just a few questions but otherwise approved 👍 nice!

Show resolved Hide resolved app/dashboard/models.py
Show resolved Hide resolved app/dashboard/models.py
Show resolved Hide resolved app/dashboard/templates/dashboard/sidebar_search_hackathon.html
@thelostone-mc

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

@gitcoinco/engineers So look like the hackathon event association does get ported over in merge_bounty 🤷‍♂
False alarm! Added the overridden fields there and tested it out.
Overrides stay on blockchain interaction steps

Screenshot 2019-06-19 at 10 26 34 PM

@thelostone-mc thelostone-mc requested a review from octavioamu Jun 19, 2019

@octavioamu
Copy link
Collaborator

left a comment

LGTM

@danlipert

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

@thelostone-mc we'll need to rename the migration to 0035 and fix, I have one for dashboard as well (lots of migrations this deploy)

@thelostone-mc thelostone-mc added this to Review-Pending in PR Review Board Jun 23, 2019

@thelostone-mc thelostone-mc dismissed stale reviews from danlipert and octavioamu via f9ad9b8 Jun 24, 2019

@thelostone-mc thelostone-mc merged commit d21f61f into master Jun 24, 2019

2 of 4 checks passed

codecov/patch 20% of diff hit (target 30.43%)
Details
codecov/project 30.43% (-0.01%) compared to 3649843
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

PR Review Board automation moved this from Review-Pending to Done Jun 24, 2019

thelostone-mc added a commit that referenced this pull request Jun 26, 2019

@thelostone-mc thelostone-mc deleted the override branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.