Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add beyond_blockhain hackathon page #4657

Merged
merged 2 commits into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@thelostone-mc
Copy link
Member

commented Jun 19, 2019

Description
  • updated model to add unique identifer
  • created config file to store sponsors list
  • added custom styling for the page
Refers/Fixes

This should go in POST #4645

Testing

Beyond Blockchain Page

EVH Page

@thelostone-mc thelostone-mc requested a review from gitcoinco/engineers Jun 19, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 19, 2019

Codecov Report

Merging #4657 into master will decrease coverage by 0.1%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4657      +/-   ##
=========================================
- Coverage    30.4%   30.3%   -0.11%     
=========================================
  Files         213     214       +1     
  Lines       17113   17122       +9     
  Branches     2312    2313       +1     
=========================================
- Hits         5204    5188      -16     
- Misses      11700   11727      +27     
+ Partials      209     207       -2
Impacted Files Coverage Δ
app/dashboard/context/hackathon_explorer.py 0% <0%> (ø)
app/dashboard/views.py 14.31% <0%> (-0.04%) ⬇️
app/dashboard/models.py 56.85% <100%> (+0.02%) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️
app/dashboard/utils.py 34.49% <0%> (-2.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a39ed8...d1d4bfb. Read the comment docs.

@octavioamu
Copy link
Collaborator

left a comment

Hey @thelostone-mc I had checked the code and looks goods but just have one point, this file size is 8mb and in this case doesn't really make sense to be a svg can we create a png from that instead?
https://github.com/gitcoinco/web/blob/31c550b584bbb34e9fa1b3d452facd5eae1fbe87/app/assets/v2/images/hackathon/beyond_block/logo.svg
and

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:hackathon branch from 31c550b to 5079620 Jun 20, 2019

thelostone-mc added some commits Jun 14, 2019

feat: add beyond_blockhain hackathon page
- update typeform link
- updated hackahton banner
- updated model to add unique identifer
- created config file to store sponsors list
- added custom styling for the page

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:hackathon branch from 5079620 to d1d4bfb Jun 20, 2019

@danlipert danlipert merged commit 01c2ae9 into gitcoinco:master Jun 20, 2019

1 of 3 checks passed

codecov/patch 11.11% of diff hit (target 30.4%)
Details
codecov/project 30.3% (-0.11%) compared to 3a39ed8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thelostone-mc thelostone-mc deleted the thelostone-mc:hackathon branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.