Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newletter position #4659

Merged
merged 1 commit into from Jun 22, 2019

Conversation

Projects
None yet
2 participants
@iamonuwa
Copy link
Contributor

commented Jun 19, 2019

Description

The current newletter form on the /requests is off.

Refers/Fixes

Fixes #3632

Testing
@iamonuwa

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

Screenshot from 2019-06-20 00-12-09

@codecov

This comment has been minimized.

Copy link

commented Jun 19, 2019

Codecov Report

Merging #4659 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4659   +/-   ##
=======================================
  Coverage   30.08%   30.08%           
=======================================
  Files         213      213           
  Lines       17112    17112           
  Branches     2311     2311           
=======================================
  Hits         5148     5148           
  Misses      11764    11764           
  Partials      200      200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ed0a0...574b021. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 19, 2019

Codecov Report

Merging #4659 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4659   +/-   ##
======================================
  Coverage    30.3%   30.3%           
======================================
  Files         214     214           
  Lines       17141   17141           
  Branches     2319    2319           
======================================
  Hits         5195    5195           
  Misses      11739   11739           
  Partials      207     207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 789bdac...4fc8cc3. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the iamonuwa:master branch from 574b021 to 4fc8cc3 Jun 22, 2019

@thelostone-mc
Copy link
Member

left a comment

re-did the commit and avoided adding extra divs

@thelostone-mc thelostone-mc merged commit 651abf6 into gitcoinco:master Jun 22, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 789bdac...4fc8cc3
Details
codecov/project 30.3% remains the same compared to 789bdac
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.