Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styling on bounty flow #487

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@coderberry
Copy link
Contributor

commented Feb 23, 2018

This PR fixes some styling issues that existed in the bounty wizard (4 steps).

Fixes: #429

@thelostone-mc

This comment has been minimized.

Copy link
Member

commented Feb 23, 2018

refactoring + reindenting == ❤️

@coderberry

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2018

@thelostone-mc Agreed. 4 spaces for HTML is not ideal :(

Can you help me understand how to get the tests passing? I'm new to this codebase

@owocki

This comment has been minimized.

Copy link
Member

commented Feb 26, 2018

i believe that @jasonrhaas put in a fix that helps get the test passing. try merging in master if you get a chance

@thelostone-mc

This comment has been minimized.

Copy link
Member

commented Feb 26, 2018

@coderberry Ah sorry I missed this. Not sure on how to change the test rules. Let me dig up on that

Also could we change this ?

Source : https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/

@PixelantDesign

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

related to #429

@thelostone-mc thelostone-mc referenced this pull request Feb 27, 2018

Merged

dashboard: base setup #505

2 of 2 tasks complete
@mbeacom

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2018

@coderberry @PixelantDesign Is this something that you still want merged? If so, would you mind resolving the conflicts or I can set aside some time to resolve them later this afternoon.

@PixelantDesign

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

I would say no at this time since @olaf has already started implementing the new redesign. Thanks Eric!

@mbeacom mbeacom deleted the berry/429-bounty-creation-process branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.