Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign and implementation of embed widget #644

Merged
merged 7 commits into from Mar 19, 2018

Conversation

Projects
None yet
3 participants
@michelgotta
Copy link
Contributor

commented Mar 18, 2018

This is a major redesign and refactoring of the embed widget. For better code quality, code could use some more refactoring. Took the existing code as a base.

  • Better font rendering and "anti alias"
  • Overall more robust display of issues

Fixes: Issue 594

@codecov

This comment has been minimized.

Copy link

commented Mar 18, 2018

Codecov Report

Merging #644 into master will increase coverage by 0.18%.
The diff coverage is 1.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   34.77%   34.96%   +0.18%     
==========================================
  Files          90       90              
  Lines        5009     4985      -24     
  Branches      572      570       -2     
==========================================
+ Hits         1742     1743       +1     
+ Misses       3201     3176      -25     
  Partials       66       66
Impacted Files Coverage Δ
app/dashboard/embed.py 6.22% <1.85%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b4bc6...799e9e6. Read the comment docs.

@michelgotta

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2018

@owocki This was the first time I submitted work through gitcoin.co interface.
I hope I have done everything right… 😬

@owocki

This comment has been minimized.

Copy link
Member

commented Mar 19, 2018

@michelgotta you did it right!

mind posting an example of what the image output for this looks like, or is it prettymuch this?

gitcoin-embed-widget-redesign-fixed

@mbeacom mbeacom added frontend embedded and removed frontend labels Mar 19, 2018

@owocki

This comment has been minimized.

Copy link
Member

commented Mar 19, 2018

i say lets :shipit: !

@mbeacom mbeacom merged commit e5e6494 into gitcoinco:master Mar 19, 2018

2 of 3 checks passed

codecov/patch 1.85% of diff hit (target 34.77%)
Details
codecov/project 34.96% (+0.18%) compared to f3b4bc6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@michelgotta michelgotta deleted the michelgotta:michelgotta/embed-widget-implementation branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.