Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds testimonial video to landing page #645

Merged
merged 2 commits into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@owocki
Copy link
Member

commented Mar 19, 2018

Adds this testimonial video to the landing page:
https://www.youtube.com/watch?v=hpqHJCiqXzA&feature=youtu.be

Screenshot:

screen shot 2018-03-18 at 7 13 42 pm

@owocki owocki added the in progress label Mar 19, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2018

i've also put the video(s) up at https://github.com/gitcoinco/creative/tree/master/video

submitting this PR to put the idea on the table.

i know that @PixelantDesign had some concerns about the graphical style of this testimonial video... so we may want to hold off on putting this on the landing page and only use it in a limited content way until we have better avatar assets and an agreed upon video style guide.

@codecov

This comment has been minimized.

Copy link

commented Mar 19, 2018

Codecov Report

Merging #645 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   34.74%   34.74%           
=======================================
  Files          90       90           
  Lines        5011     5011           
  Branches      573      573           
=======================================
  Hits         1741     1741           
  Misses       3204     3204           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef1d214...d42e358. Read the comment docs.

<div class="col d-flex flex-column align-items-center animatedParent youtube">
<iframe style="height:288px; width:500px; " src="https://www.youtube.com/embed/hpqHJCiqXzA" class="animated fadeInRightShort" frameborder="0" allowfullscreen></iframe>
</div>

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc Mar 19, 2018

Member

@mbeacom Does our linter catch empty lines?

This comment has been minimized.

Copy link
@mbeacom

mbeacom Mar 19, 2018

Contributor

@thelostone-mc Nothing that I can see. Is this popping up on your linter? If so, which linter and any additional rules?

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc Mar 19, 2018

Member

@mbeacom This one : "no-multiple-empty-lines": "error"
Doc: link

If needed , I can shoot out a PR with this

This comment has been minimized.

Copy link
@mbeacom

mbeacom Mar 19, 2018

Contributor
@thelostone-mc
Copy link
Member

left a comment

LGTM

@owocki owocki merged commit 6dfd349 into master Mar 20, 2018

4 checks passed

codecov/patch Coverage not affected when comparing ef1d214...d42e358
Details
codecov/project 34.74% remains the same compared to ef1d214
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@owocki owocki removed the in progress label Mar 20, 2018

@mbeacom mbeacom deleted the kevin/testimonials branch Mar 21, 2018

@mbeacom mbeacom added the frontend label Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.