Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People shouldn't be able to start work on more than 3 issues at a time #663

Merged
merged 2 commits into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@owocki
Copy link
Member

commented Mar 20, 2018

Description

Fixes #478 - People shouldn't be able to start work on more than 3 issues at a time

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

interest

Testing

tested it

Refers/Fixes

#478

@owocki owocki added the in progress label Mar 20, 2018

@codecov

This comment has been minimized.

Copy link

commented Mar 20, 2018

Codecov Report

Merging #663 into master will increase coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage    34.8%   34.89%   +0.09%     
==========================================
  Files          90       90              
  Lines        5014     5055      +41     
  Branches      572      589      +17     
==========================================
+ Hits         1745     1764      +19     
- Misses       3203     3225      +22     
  Partials       66       66
Impacted Files Coverage Δ
app/dashboard/views.py 18.76% <0%> (-0.34%) ⬇️
app/faucet/admin.py 71.42% <0%> (-5.05%) ⬇️
app/faucet/views.py 22.98% <0%> (-2.69%) ⬇️
app/faucet/models.py 88.88% <0%> (-2.42%) ⬇️
...eting/management/commands/expiration_start_work.py 86.15% <0%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f696fbb...ffcedbf. Read the comment docs.

status=401)

try:
bounty = Bounty.objects.get(pk=bounty_id)
except Bounty.DoesNotExist:
raise Http404

num_issues = 3
active_bounties = Bounty.objects.filter(idx_status__in=['open', 'started'])

This comment has been minimized.

Copy link
@mbeacom

mbeacom Mar 20, 2018

Contributor

Should we use current().filter(...) or filter(current_bounty=True, ...) ?

This comment has been minimized.

Copy link
@owocki

owocki Mar 20, 2018

Author Member

this is why we code review what i wrote at 10pm with a glass of 🥃 in my hand :P

This comment has been minimized.

Copy link
@mbeacom

mbeacom Mar 20, 2018

Contributor

😂

This comment has been minimized.

Copy link
@owocki
num_issues = 3
active_bounties = Bounty.objects.filter(idx_status__in=['open', 'started'])
num_active = Interest.objects.filter(profile_id=profile_id, bounty__in=active_bounties).count()
is_working_on_too_much_stuff = num_active > num_issues

This comment has been minimized.

Copy link
@mbeacom

mbeacom Mar 20, 2018

Contributor

Will we want to check >= here?

This comment has been minimized.

Copy link
@owocki

owocki Mar 20, 2018

Author Member

yes

This comment has been minimized.

Copy link
@owocki

@owocki owocki merged commit 3b62af5 into master Mar 21, 2018

3 of 4 checks passed

codecov/patch 0% of diff hit (target 34.8%)
Details
codecov/project 34.89% (+0.09%) compared to f696fbb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@owocki owocki removed the in progress label Mar 21, 2018

@mbeacom mbeacom deleted the kevin/max_issues_at_once branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.