Records UserAction events for Tip, Start/Stop Work, and Bounty related things #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
==========================================
- Coverage 34.8% 34.67% -0.13%
==========================================
Files 90 90
Lines 5014 5038 +24
Branches 572 575 +3
==========================================
+ Hits 1745 1747 +2
- Misses 3203 3225 +22
Partials 66 66
Continue to review full report at Codecov.
|
mbeacom
approved these changes
Mar 20, 2018
mbeacom
reviewed
Mar 21, 2018
app/dashboard/helpers.py
Outdated
| @@ -469,6 +468,7 @@ def record_user_action(event_name, old_bounty, new_bounty): | |||
| metadata={ | |||
| 'new_bounty': new_bounty.pk if new_bounty else None, | |||
| 'old_bounty': old_bounty.pk if old_bounty else None, | |||
| 'fulfillment': fulfillment, | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Records
UserActionevents for Tip, Start/Stop Work, and Bounty related eventsChecklist
Affected core subsystem(s)
Analytics
This is a continuation of #513 but without all the weird sync_profile changes