Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounty: fixed avatar url + tooltip style #784

Merged
merged 3 commits into from Apr 6, 2018

Conversation

thelostone-mc
Copy link
Member

Description
Tooltip update

screen shot 2018-04-04 at 3 23 52 pm

If owners github info is not found

screen shot 2018-04-04 at 3 16 57 pm

Owners profile photo

screen shot 2018-04-04 at 3 17 42 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • bounty.js
Refers/Fixes

@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@f8e767c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #784   +/-   ##
=========================================
  Coverage          ?   33.87%           
=========================================
  Files             ?      101           
  Lines             ?     5712           
  Branches          ?      669           
=========================================
  Hits              ?     1935           
  Misses            ?     3698           
  Partials          ?       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e767c...cad1eee. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @PixelantDesign Are you good with this?

@mbeacom mbeacom added needs review frontend This needs frontend expertise. labels Apr 4, 2018
@owocki
Copy link
Contributor

owocki commented Apr 4, 2018

looks good so far!

personally id like to see the repo avatar in the top left next to the issue title bc i think it helps visually identify the repo that the bounty hunter will be working for... but i dont know if the design allows for that and/or if @PixelantDesign would agree

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Apr 4, 2018

I think we can add the repo icon in the upper left. @owocki
@thelostone-mc Looking great!!!! Don't hate us, we're almost there!

Here is a mock with the avatar up top...
screen shot 2018-04-04 at 2 13 39 pm

The activity feed is meant to be a history, could we follow the accept bounty model for the stop work?
screen shot 2018-04-04 at 2 08 20 pm

screen shot 2018-04-04 at 2 08 08 pm

Thanks!

@thelostone-mc
Copy link
Member Author

I'll add the org avatar here!
I'll shoot out Accept Button -> Dropdown as another PR @mbeacom ?

@owocki
Copy link
Contributor

owocki commented Apr 4, 2018

I'll add the org avatar here!

awesome!

I'll shoot out Accept Button -> Dropdown as another PR @mbeacom ?

makes sense to me

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Apr 5, 2018

@mbeacom @owocki Done + Conflicts resolved!!

x

Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looiks good -- excited to ship!

@owocki owocki merged commit 3bae6a1 into gitcoinco:master Apr 6, 2018
@thelostone-mc thelostone-mc deleted the avatar branch April 7, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants