From 2c41b87c12244a0a81ddf0707ab7fc67d2134b7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Fi=C5=A1era?= Date: Wed, 15 Jan 2020 21:52:32 +0100 Subject: [PATCH 1/2] Use wildcard patch version for GitExtensions.Extensibility package reference. --- .../GitExtensions.PluginManager.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/GitExtensions.PluginManager/GitExtensions.PluginManager.csproj b/src/GitExtensions.PluginManager/GitExtensions.PluginManager.csproj index 2ccf14b..2069d9c 100644 --- a/src/GitExtensions.PluginManager/GitExtensions.PluginManager.csproj +++ b/src/GitExtensions.PluginManager/GitExtensions.PluginManager.csproj @@ -17,7 +17,7 @@ - + From 0824aa9ac5787bd1ca8ed44d9aa9a5040461cc41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Fi=C5=A1era?= Date: Wed, 15 Jan 2020 21:54:33 +0100 Subject: [PATCH 2/2] Fix plugin settings for GitExtensions-v3.3.1. Use base constructor of GitPluginBase with boolean parameter to indicate that plugin has settings. --- src/GitExtensions.PluginManager/Plugin.cs | 1 + src/GitExtensions.PluginManager/PluginSettings.cs | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/GitExtensions.PluginManager/Plugin.cs b/src/GitExtensions.PluginManager/Plugin.cs index ab9479d..ce619f1 100644 --- a/src/GitExtensions.PluginManager/Plugin.cs +++ b/src/GitExtensions.PluginManager/Plugin.cs @@ -29,6 +29,7 @@ public class Plugin : GitPluginBase internal PluginSettings Configuration { get; private set; } public Plugin() + : base(PluginSettings.HasProperties) { Name = "Plugin Manager"; Description = "Plugin Manager"; diff --git a/src/GitExtensions.PluginManager/PluginSettings.cs b/src/GitExtensions.PluginManager/PluginSettings.cs index 3c8029e..36b35af 100644 --- a/src/GitExtensions.PluginManager/PluginSettings.cs +++ b/src/GitExtensions.PluginManager/PluginSettings.cs @@ -31,6 +31,8 @@ public PluginSettings(ISettingsSource source) private static readonly List properties; + public static bool HasProperties => properties.Count > 0; + static PluginSettings() { properties = new List(1)