Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding known host does not work for non standard ports #2882

Closed
pvginkel opened this issue Jul 22, 2015 · 8 comments
Closed

Adding known host does not work for non standard ports #2882

pvginkel opened this issue Jul 22, 2015 · 8 comments
Labels
status: abandoned type: bug 🐛 up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/

Comments

@pvginkel
Copy link
Contributor

I'm using Gerrit which has SSH running on the non standard port 29418. Automatically adding a known host doesn't work in that instance. The command box that opens clearly connects to the default SSH port; not the non-standard one. Since they are using different SSH certificates, the wrong host is added. Instead plink should be run as plink -P 29418 host.

@KindDragon KindDragon added type: bug 🐛 up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels Apr 29, 2016
@CookiePLMonster
Copy link

Oddly enough, a PR from 2014 claims to have that fixed - but it's still an issue in 2017.

@RussKie
Copy link
Member

RussKie commented Sep 19, 2017

Which PR are referring to?
This bug is still open and it is still up for grabs.
You are welcome to volunteer and submit a fix

@CookiePLMonster
Copy link

Oh well, looks like the thing I found only concerns Test Connection and not pulling/pushing?

See #47 and cf807d4

@CookiePLMonster
Copy link

CookiePLMonster commented Sep 19, 2017

OK, so looks like this is actually implemented and working! My issue lied elsewhere - paths to plink/pageant I set in Settings -> SSH were not in line with those stored in registry HKCU\Software\GitExtensions and therefore Test Connection used a different plink.exe than Pull does.

image

image

gitssh key updated itself after I re-saved settings in this page - but as seen, plink/pageant/puttygen are still wrong.

@RussKie
Copy link
Member

RussKie commented Sep 19, 2017 via email

@CookiePLMonster
Copy link

UI for Test Connection relies on the one from registry (so if gitssh reg entry doesn't point to plink.exe, Test Connection button is gone), however when launched the option uses plink from Settings. Pull/Fetch and Update remote branch info always use plink from registry.

So if both paths point to valid plink (which is easy since they point to GitExt's plink by default and users might have changed the option in Settings to point to a separate plink) incosistencies like this can occur.

I'm currently working on noting down a reliable repro path for desyncing those without messing with registry keys manually and I'll redirect this discussion there.

@CookiePLMonster
Copy link

CookiePLMonster commented Sep 19, 2017

Created #4011 - let's move the discussion here.

Long story short - issue OP had seems to be fixed provided paths to plink are correct - I'm now able to pull from SSH over port 2322 with no problems.

@GintasS
Copy link
Collaborator

GintasS commented Aug 18, 2021

Discussion was moved to #4011, need to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: abandoned type: bug 🐛 up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/
Projects
None yet
Development

No branches or pull requests

5 participants