Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NBug] Value cannot be null.Parameter name: value #6549

Closed
thimmy687 opened this issue May 11, 2019 · 8 comments

Comments

@thimmy687
Copy link

commented May 11, 2019

Current behaviour

Open repository for path "C:" crash the app

Expected behaviour

some error msg instead

Steps to reproduce

Language is german

C:\ is a valid path on my machnie, but no git repository

Error Details

System.ArgumentNullException: Value cannot be null.
Parameter name: value
   at System.String.StartsWith(String value)
   at GitUI.CommandsDialogs.BrowseDialog.GitStatusMonitor.<.ctor>g__WorkTreeChanged|23_3(Object sender, FileSystemEventArgs e)
   at System.IO.FileSystemWatcher.OnChanged(FileSystemEventArgs e)
   at System.IO.FileSystemWatcher.CompletionStatusChanged(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* overlappedPointer)
   at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP)

Environment

  • Git Extensions 3.1.0.5766-RC1
  • Build 497059b (Dirty)
  • Git 2.19.0.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3394.0
  • DPI 96dpi (no scaling)
@thimmy687

This comment has been minimized.

Copy link
Author

commented May 11, 2019

If I click in the opening Error window on copy an unhandled exception occured:

image

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.Threading.ThreadStateException: Current thread must be set to single thread apartment (STA) mode before OLE calls can be made. Ensure that your Main function has STAThreadAttribute marked on it.
   at System.Windows.Forms.Clipboard.SetDataObject(Object data, Boolean copy, Int32 retryTimes, Int32 retryDelay)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3394.0 built by: NET472REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
----------------------------------------
GitExtensions
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/GitExtensions.exe
----------------------------------------
System
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3362.0 built by: NET472REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
NBug
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/NBug.DLL
----------------------------------------
System.Core
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3362.0 built by: NET472REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------
System.Windows.Forms
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3324.0 built by: NET472REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System.Drawing
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
GitExtUtils
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/GitExtUtils.DLL
----------------------------------------
GitUI
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/GitUI.DLL
----------------------------------------
System.Xml.Linq
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml.Linq/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.Linq.dll
----------------------------------------
System.Configuration
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Xml
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.VisualStudio.Threading
    Assembly Version: 15.8.0.0
    Win32 Version: 15.8.132.4684
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/Microsoft.VisualStudio.Threading.DLL
----------------------------------------
ResourceManager
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/ResourceManager.DLL
----------------------------------------
GitUIPluginInterfaces
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/GitUIPluginInterfaces.DLL
----------------------------------------
GitCommands
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/GitCommands.DLL
----------------------------------------
Microsoft.VisualStudio.Validation
    Assembly Version: 15.3.0.0
    Win32 Version: 15.3.15.16354
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/Microsoft.VisualStudio.Validation.DLL
----------------------------------------
System.IO.Abstractions
    Assembly Version: 2.0.0.144
    Win32 Version: 2.0.0.144
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.IO.Abstractions.DLL
----------------------------------------
System.Deployment
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Deployment/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Deployment.dll
----------------------------------------
System.ValueTuple
    Assembly Version: 4.0.3.0
    Win32 Version: 4.6.26515.06
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.ValueTuple.DLL
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Accessibility
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------
AdysTech.CredentialManager
    Assembly Version: 1.7.0.0
    Win32 Version: 1.7.0.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/AdysTech.CredentialManager.DLL
----------------------------------------
Microsoft.WindowsAPICodePack.Shell
    Assembly Version: 1.1.3.3
    Win32 Version: 1.1.3.3
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/Microsoft.WindowsAPICodePack.Shell.DLL
----------------------------------------
System.Collections.Immutable
    Assembly Version: 1.2.3.0
    Win32 Version: 4.6.26515.06
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Collections.Immutable.DLL
----------------------------------------
SmartFormat
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.0.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/SmartFormat.DLL
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Reactive.Linq
    Assembly Version: 3.0.3000.0
    Win32 Version: 3.1.1.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Reactive.Linq.DLL
----------------------------------------
System.Reactive.Interfaces
    Assembly Version: 3.0.1000.0
    Win32 Version: 3.1.1.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Reactive.Interfaces.DLL
----------------------------------------
System.Reactive.Core
    Assembly Version: 3.0.3000.0
    Win32 Version: 3.1.1.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Reactive.Core.DLL
----------------------------------------
System.Reactive.PlatformServices
    Assembly Version: 3.0.3000.0
    Win32 Version: 3.1.1.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Reactive.PlatformServices.DLL
----------------------------------------
ICSharpCode.TextEditor
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/ICSharpCode.TextEditor.DLL
----------------------------------------
Microsoft.WindowsAPICodePack
    Assembly Version: 1.1.3.3
    Win32 Version: 1.1.3.3
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/Microsoft.WindowsAPICodePack.DLL
----------------------------------------
Microsoft.VisualStudio.Composition
    Assembly Version: 15.6.0.0
    Win32 Version: 15.6.36.41634
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/Microsoft.VisualStudio.Composition.DLL
----------------------------------------
AppVeyorIntegration
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/AppVeyorIntegration.DLL
----------------------------------------
Atlassian.Jira
    Assembly Version: 10.0.2.0
    Win32 Version: 10.0.2.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Atlassian.Jira.DLL
----------------------------------------
AutoCompileSubmodules
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/AutoCompileSubmodules.DLL
----------------------------------------
AzureDevOpsIntegration
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/AzureDevOpsIntegration.DLL
----------------------------------------
BackgroundFetch
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/BackgroundFetch.DLL
----------------------------------------
Bitbucket
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Bitbucket.DLL
----------------------------------------
CreateLocalBranches
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/CreateLocalBranches.DLL
----------------------------------------
System.DirectoryServices
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.DirectoryServices/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.DirectoryServices.dll
----------------------------------------
DeleteUnusedBranches
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/DeleteUnusedBranches.DLL
----------------------------------------
FindLargeFiles
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/FindLargeFiles.DLL
----------------------------------------
Gerrit
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Gerrit.DLL
----------------------------------------
GitFlow
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/GitFlow.DLL
----------------------------------------
GitHub3
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/GitHub3.DLL
----------------------------------------
GitImpact
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/GitImpact.DLL
----------------------------------------
GitStatistics
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/GitStatistics.DLL
----------------------------------------
Gource
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Gource.DLL
----------------------------------------
JenkinsIntegration
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/JenkinsIntegration.DLL
----------------------------------------
JiraCommitHintPlugin
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/JiraCommitHintPlugin.DLL
----------------------------------------
Microsoft.TeamFoundation.Build2.WebApi
    Assembly Version: 15.0.0.0
    Win32 Version: 15.112.26224.0 built by: releases/dev15vsrtw (f9b80575fc)
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Microsoft.TeamFoundation.Build2.WebApi.DLL
----------------------------------------
Microsoft.TeamFoundation.Common
    Assembly Version: 15.0.0.0
    Win32 Version: 15.112.26224.0 built by: releases/dev15vsrtw (f9b80575fc)
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Microsoft.TeamFoundation.Common.DLL
----------------------------------------
Microsoft.TeamFoundation.Core.WebApi
    Assembly Version: 15.0.0.0
    Win32 Version: 15.112.26224.0 built by: releases/dev15vsrtw (f9b80575fc)
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Microsoft.TeamFoundation.Core.WebApi.DLL
----------------------------------------
Microsoft.VisualStudio.Services.Common
    Assembly Version: 15.0.0.0
    Win32 Version: 15.112.26224.0 built by: releases/dev15vsrtw (f9b80575fc)
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Microsoft.VisualStudio.Services.Common.DLL
----------------------------------------
Microsoft.VisualStudio.Services.WebApi
    Assembly Version: 15.0.0.0
    Win32 Version: 15.112.26224.0 built by: releases/dev15vsrtw (f9b80575fc)
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Microsoft.VisualStudio.Services.WebApi.DLL
----------------------------------------
Newtonsoft.Json
    Assembly Version: 10.0.0.0
    Win32 Version: 10.0.3.21018
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/Newtonsoft.Json.DLL
----------------------------------------
NString
    Assembly Version: 1.2.0.0
    Win32 Version: 1.2.0.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/NString.DLL
----------------------------------------
ProxySwitcher
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/ProxySwitcher.DLL
----------------------------------------
ReleaseNotesGenerator
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/ReleaseNotesGenerator.DLL
----------------------------------------
System.Net.Http.Formatting
    Assembly Version: 5.2.2.0
    Win32 Version: 5.2.20826.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/System.Net.Http.Formatting.DLL
----------------------------------------
TeamCityIntegration
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/TeamCityIntegration.DLL
----------------------------------------
TfsIntegration
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/TfsIntegration.DLL
----------------------------------------
TfsInterop.Vs2012
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/TfsInterop.Vs2012.DLL
----------------------------------------
TfsInterop.Vs2015
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/plugins/TfsInterop.Vs2015.DLL
----------------------------------------
System.Threading.Tasks.Dataflow
    Assembly Version: 4.5.24.0
    Win32 Version: 4.5.24.0
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Threading.Tasks.Dataflow.DLL
----------------------------------------
System.Threading.Tasks
    Assembly Version: 4.0.11.0
    Win32 Version: 4.6.25714.01
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Threading.Tasks.DLL
----------------------------------------
netstandard
    Assembly Version: 2.0.0.0
    Win32 Version: 4.7.3056.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/netstandard/v4.0_2.0.0.0__cc7b13ffcd2ddd51/netstandard.dll
----------------------------------------
System.Runtime
    Assembly Version: 4.1.2.0
    Win32 Version: 4.6.25714.01
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Runtime.DLL
----------------------------------------
System.Collections.Concurrent
    Assembly Version: 4.0.11.0
    Win32 Version: 4.6.25714.01
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Collections.Concurrent.DLL
----------------------------------------
System.Diagnostics.Tracing
    Assembly Version: 4.2.0.0
    Win32 Version: 4.6.26011.01
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Diagnostics.Tracing.DLL
----------------------------------------
System.ComponentModel.Composition
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.ComponentModel.Composition/v4.0_4.0.0.0__b77a5c561934e089/System.ComponentModel.Composition.dll
----------------------------------------
RestSharp
    Assembly Version: 106.2.1.0
    Win32 Version: 106.2.1.1
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/RestSharp.DLL
----------------------------------------
ConEmu.WinForms
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/ConEmu.WinForms.DLL
----------------------------------------
System.Net.Http
    Assembly Version: 4.2.0.0
    Win32 Version: 4.6.26011.01
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Net.Http.DLL
----------------------------------------
System.ServiceModel
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3324.0 built by: NET472REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.ServiceModel/v4.0_4.0.0.0__b77a5c561934e089/System.ServiceModel.dll
----------------------------------------
System.Runtime.Serialization
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3324.0 built by: NET472REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.Serialization/v4.0_4.0.0.0__b77a5c561934e089/System.Runtime.Serialization.dll
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Composition.AttributedModel
    Assembly Version: 1.0.31.0
    Win32 Version: 4.6.24705.01
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Composition.AttributedModel.DLL
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.ComponentModel.DataAnnotations
    Assembly Version: 4.0.0.0
    Win32 Version: 4.7.3056.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.ComponentModel.DataAnnotations/v4.0_4.0.0.0__31bf3856ad364e35/System.ComponentModel.DataAnnotations.dll
----------------------------------------
Git.hub
    Assembly Version: 3.1.0.5766
    Win32 Version: 3.1.0.5766
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/Git.hub.DLL
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.7.3056.0 built by: NET472REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Runtime.InteropServices.RuntimeInformation
    Assembly Version: 4.0.2.0
    Win32 Version: 4.6.26011.01
    CodeBase: file:///C:/Program%20Files%20(x86)/GitExtensions-RC/System.Runtime.InteropServices.RuntimeInformation.DLL
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

@gerhardol

This comment has been minimized.

Copy link
Member

commented May 11, 2019

On a slightly different build, I get another exception

Error Details

System.UriFormatException: Ogiltig URI. Det gick inte att bestämma formatet för URI:n.
   vid System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   vid GitCommands.PathUtil.NormalizePath(String path) i F:\dev\gc\gitextensions\GitCommands\PathUtil.cs:rad 134
   vid GitCommands.GitModule..ctor(String workingDir) i F:\dev\gc\gitextensions\GitCommands\Git\GitModule.cs:rad 45
   vid GitUI.CommandsDialogs.BrowseDialog.FormOpenDirectory.LoadClick(Object sender, EventArgs e) i F:\dev\gc\gitextensions\GitUI\CommandsDialogs\BrowseDialog\FormOpenDirectory.cs:rad 100
   vid System.Windows.Forms.Control.OnClick(EventArgs e)
   vid System.Windows.Forms.Button.OnClick(EventArgs e)
   vid System.Windows.Forms.Button.PerformClick()
   vid System.Windows.Forms.Form.ProcessDialogKey(Keys keyData)
   vid System.Windows.Forms.Control.PreProcessMessage(Message& msg)
   vid System.Windows.Forms.Control.PreProcessControlMessageInternal(Control target, Message& msg)
   vid System.Windows.Forms.Application.ThreadContext.PreTranslateMessage(MSG& msg)

Environment

  • Git Extensions 3.1.0
  • Build f11fad3e20bfc3bbd33377caa22f7ef44da0093f (Dirty)
  • Git 2.21.0.windows.1
  • Microsoft Windows NT 10.0.17763.0
  • .NET Framework 4.7.3324.0
  • DPI 96dpi (no scaling)
@RussKie RussKie added this to the 3.2.0 milestone May 14, 2019
@RussKie

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@thimmy687 could you please provide steps to reproduce - I can't open open non-git repo.

An attempt to open an invalid repo from the dashboard results in the following dialog:
image

An attempt to open a non-git repo via Start > Recent > C:\ results in the following dialog:
image

An attempt to open via Start > Open... > C:\ does nothing

An attempt to open via Start > Open... > C: results in the error that @gerhardol shown above. That's an easy fix to ignore the error.

RussKie added a commit to RussKie/gitextensions that referenced this issue May 14, 2019
Attempt to open a repository at an invalid path (e.g. "C:" instead of
"C:\") would result in the following error:

    System.UriFormatException
      HResult=0x80131537
      Message=Invalid URI: The format of the URI could not be determined.
      Source=System
      StackTrace:
       at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
       at GitCommands.PathUtil.NormalizePath(String path)
       at GitCommands.GitModule..ctor(String workingDir)
       at GitUI.CommandsDialogs.BrowseDialog.FormOpenDirectory.LoadClick(Object sender, EventArgs e)

Relates to gitextensions#6549
Relates to gitextensions#6556
RussKie added a commit to RussKie/gitextensions that referenced this issue May 14, 2019
Attempt to open a repository at an invalid path (e.g. "C:" instead of
"C:\") would result in the following error:

    System.UriFormatException
      HResult=0x80131537
      Message=Invalid URI: The format of the URI could not be determined.
      Source=System
      StackTrace:
       at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
       at GitCommands.PathUtil.NormalizePath(String path)
       at GitCommands.GitModule..ctor(String workingDir)
       at GitUI.CommandsDialogs.BrowseDialog.FormOpenDirectory.LoadClick(Object sender, EventArgs e)

The fix ignores `UriFormatException` that leads to the module be ignore,
if it isn't a valid git repo.

Relates to gitextensions#6549
Relates to gitextensions#6556
RussKie added a commit to RussKie/gitextensions that referenced this issue May 15, 2019
Attempt to open a repository at an invalid path (e.g. "C:" instead of
"C:\") would result in the following error:

    System.UriFormatException
      HResult=0x80131537
      Message=Invalid URI: The format of the URI could not be determined.
      Source=System
      StackTrace:
       at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
       at GitCommands.PathUtil.NormalizePath(String path)
       at GitCommands.GitModule..ctor(String workingDir)
       at GitUI.CommandsDialogs.BrowseDialog.FormOpenDirectory.LoadClick(Object sender, EventArgs e)

The fix adds checks around the user supplied path.

Relates to gitextensions#6549
Relates to gitextensions#6556
RussKie added a commit to RussKie/gitextensions that referenced this issue May 16, 2019
Attempt to open a repository at an invalid path (e.g. "C:" instead of
"C:\") would result in the following error:

    System.UriFormatException
      HResult=0x80131537
      Message=Invalid URI: The format of the URI could not be determined.
      Source=System
      StackTrace:
       at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
       at GitCommands.PathUtil.NormalizePath(String path)
       at GitCommands.GitModule..ctor(String workingDir)
       at GitUI.CommandsDialogs.BrowseDialog.FormOpenDirectory.LoadClick(Object sender, EventArgs e)

The fix adds checks around the user supplied path.

Relates to gitextensions#6549
Relates to gitextensions#6556
@gerhardol

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@thimmy687
Is this fixed?

@illfated

This comment has been minimized.

Copy link

commented May 30, 2019

@thimmy687 : You may want to upgrade your Git Extensions to the release version 3.1.0.5877, as well as upgrading Git to 2.21, to make sure you get more up-to-date output (even from the errors).

@AOrlov

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Sometimes it's possible to reproduce even with the current build. The problem is in GitStatusMonitor.StartWathchingChanges which might set _gitPath to null since Path.GetDirectoryName("C:\") returns null. Then GitSM.WorkTreeChanged throws the exception on line 132 if (e.FullPath.StartsWith(_gitPath)).

Solution: do not start watching changes for invalid paths Apply #6560 fix

@gerhardol

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@AOrlov
Can you make a pr?

@AOrlov

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@gerhardol
I apologize, while I was trying to reproduce with:

  • Git Extensions 3.1.1.6049
  • Build 2f87210

looks like it was fixed by #6560. Now I don't see a way to reproduce it again having master build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.