Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NBug] The path is not of a legal form. #6599

Closed
larrydolsen opened this issue May 18, 2019 · 4 comments · Fixed by #6835

Comments

@larrydolsen
Copy link

commented May 18, 2019

Current behaviour

When I close the GitHub: Remote repository fork and clone window, Git Extensions crashes with this exception.

Expected behaviour

The application should not crash.

Steps to reproduce

  1. In the menu, select GitHub>Fork/Clone repository...
  2. Click the Close button.
  3. Git Extensions crashes.

Error Details

System.ArgumentException: The path is not of a legal form.
   at System.IO.Path.LegacyNormalizePath(String path, Boolean fullCheck, Int32 maxPathLength, Boolean expandShortPaths)
   at System.IO.Path.InternalGetDirectoryName(String path)
   at GitCommands.Submodules.SubmoduleStatusProvider.GetSuperProjectRepositorySubmodulesStructure(GitModule currentModule, SubmoduleInfoResult result, String noBranchText)
   at GitCommands.Submodules.SubmoduleStatusProvider.<>c__DisplayClass16_0.<<UpdateSubmodulesStructure>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.ThreadHelper.<>c__DisplayClass13_0.<<FileAndForget>b__0>d.MoveNext()

Environment

  • Git Extensions 3.1.0.5877
  • Build bb1687f
  • Git 2.21.0.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3416.0
  • DPI 96dpi (no scaling)
@larrydolsen

This comment has been minimized.

Copy link
Author

commented May 18, 2019

After typing a valid path in the Destination folder textbox, the error no longer occurs.

@RussKie

This comment has been minimized.

Copy link
Member

commented May 19, 2019

I'm afraid I can't repro the issue.
6599-repro

Is there something else required to reproduce?

@illfated

This comment has been minimized.

Copy link

commented May 19, 2019

  • Git Extensions 3.1.0.5877
  • Build bb1687f
  • Git 2.21.0.windows.1
  • Microsoft Windows NT 10.0.17763.0
  • .NET Framework 4.7.3416.0
  • DPI 96dpi (no scaling)

Cannot reproduce. All Git Extensions does when I close the "Github: Remote repository fork and clone" window is to refresh the views in the commit list and diff view (maybe the other frames too, but the change is too small to notice).


edit: Maybe there is something inconsistent or unstable within your local repository, I don't know. I think more information is needed, like output from a git command, name/size of local repository, possible slowness of reading the repository content and so on. Difficult to troubleshoot your issue with the current information.

@Killinika

This comment has been minimized.

Copy link

commented Jun 19, 2019

I get the same issue when starting GitExtension.exe without arguments.
Could remove the problem whit editing the following file: "%appdata%\GitExtensions\GitExtensions\GitExtensions.settings"

Problem was: there was a tab character (\t) in one of the paths in the history.
After removing it the program works fine again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.