Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GE freezes when the avatar column is shown #6751

Closed
AOrlov opened this issue Jun 5, 2019 · 2 comments · Fixed by #6752

Comments

@AOrlov
Copy link
Contributor

commented Jun 5, 2019

Current behavior

GE scrolling is laggy when the avatar column is shown since the user name for each commit gets retrieved on UI thread.

Expected behavior

The avatar information should be asynchronous.

Steps to reproduce

  1. Invalidate avatar cache
  2. Open a repository with a lot of commits where some of them contain avatar icon
  3. Enable avatar column
  4. Scroll the main window

Screenshots

before

Environment

  • Git Extensions 3.1.1.6049
  • Build 2f87210
  • Git 2.21.0.windows.1
  • Microsoft Windows NT 10.0.18362.0
  • .NET Framework 4.8.3801.0
  • DPI 96dpi (no scaling)
@RussKie

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Please sign the contributors.txt before we can accept your contributions.
Thanks

@AOrlov

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

@RussKie,
all comments were addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.