Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Tab stop in commit dialog diff view has wrong width #7509

Open
slabstone opened this issue Dec 12, 2019 · 2 comments
Open

First Tab stop in commit dialog diff view has wrong width #7509

slabstone opened this issue Dec 12, 2019 · 2 comments

Comments

@slabstone
Copy link

Current behaviour

First Tab stop in commit dialog diff has width of 3 spaces, while consequent tabs have width of 4 spaces. This leads to lines not matching on whitespace width.
Also happens on lines not starting with Tabs (see screenshots).

Expected behaviour

All Tab stops must have the same width (which is at the moment fixed at 4 I guess).

Steps to reproduce

Create file, put some tabs in it, commit, change tabs to spaces, open commit dialog.

Screenshots

Text highlighted for width visualisation.

  1. line starting with Tab
    gitext-tab-width-1
  2. next Tab after first
    gitext-tab-width-2
  3. also happens on lines not starting with Tab
    gitext-tab-width-3

Did this work in previous version of GitExtensions

I don't know.

Environment

  • GitExtensions version: latest release
  • GIT version: 2.23-ish
  • OS version: Windows 7 SP1
  • .NET version: a whole bunch of different versions

Diagnostics

@gerhardol
Copy link
Member

Reproducing
The texteditor (same control) do not have this problem
One explanation is that tabstops is calculated from the first column, that has the +/- in the diff view

@mstv
Copy link
Member

mstv commented Dec 12, 2019

For me it is a "beature". Sorry, I don't want to start a flame war. But luckily, all projects I am involved in, deprecate tabs. This behavior of GE helps me to detect that somebody has not configured their editor correctly (in both directions, i.e. either tabs or spaces) -- without turning on the distracting display of nonprinting characters. That was inspiry: I will not need this "beature" anymore if I setup according hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants