Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a submodule for GitExtensions unit test #1470

Merged
merged 9 commits into from Dec 16, 2012

Conversation

Projects
None yet
6 participants
@fernsehkind
Copy link
Contributor

commented Dec 8, 2012

Maybe you can make a new repository in the gitextensions account too and fork the gitextensionstest repository from my account

@KindDragon

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2012

@spdr870 please create repository in organization for submodule

@spdr870 spdr870 merged commit 021454c into gitextensions:master Dec 16, 2012

@spdr870

This comment has been minimized.

Copy link
Member

commented Dec 16, 2012

I forked the repository and changed this submodule in this merge request.

I noticed that you only support nunit now. Is everyone ok with this change? It is no problem for me, I have both installed and its easier to support only one test platform.

@fernsehkind

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2012

Thank you!

I only want to support NUnit as test platform because:

  • Easy to maintain (support different test platform is not easy)
  • Support for Win32 and Linux
  • BSD license
@KindDragon

This comment has been minimized.

Copy link
Contributor

commented on 096097f Dec 16, 2012

Hey! If it doesn't work for Mono, this does not mean that you need to use Full Profile on Windows. Client Profile reduce a lot .NET distributive size on Windows. GitEx now will not work on a clean system, because you have not changed the installer.

This comment has been minimized.

Copy link
Contributor

replied Dec 16, 2012

Ohh, that commit was not intended for public. That commit was for test purposes only. You are right, we should try to get along with client profile.

@spdr870 or @KindDragon: Please revert this commit

This comment has been minimized.

Copy link
Contributor

replied Dec 17, 2012

Those commits supposed to be on the TestSuite branch right?

@KindDragon

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2012

NUnit not so easy to use in Visual Studio 2010, because it doesn't integrate to IDE

@feinstaub

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2012

NUnit can be integrated to VS2010 using

@feinstaub

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2012

@fernsehkind: which support for NUnit do you use?

@jbialobr

This comment has been minimized.

Copy link
Member

commented on GitCommandsTests/TranslationTest.cs in 418d4af Apr 4, 2013

What happend with this test? I don't see it in GitExtensionsTests submodule.

This comment has been minimized.

Copy link
Contributor

replied Apr 4, 2013

Yes, he delete it. I think because it depend on GitUI.

This comment has been minimized.

Copy link
Member

replied Apr 4, 2013

I think because it depend on GitUI.

Is it forbidden?

This comment has been minimized.

Copy link
Contributor

replied Apr 4, 2013

GitUI not available in submodule GitExtensionsTest

This comment has been minimized.

Copy link
Member

replied Apr 5, 2013

Should we rename it to GitExtensionsTest or add a new project for GitUI tests?

This comment has been minimized.

Copy link
Contributor

replied Apr 5, 2013

At that point, if I remember, @fernsehkind wanted to extract some classes from code that's tied to the forms so we could unit test those classes. In the end you would have forms calling other classes instead of having a lot of code that's not supposed to be in there. We never thought of creating tests for the GUI.

This comment has been minimized.

Copy link
Contributor

replied Apr 6, 2013

Thank you @fraga. That is exactly what I wanted to do. My intention was to extract some classes so that it is easier to unit test those classes. Unfortunately I never managed it because I have no time to work on GitExtensions and its test. I don't remember why I didn't move the test code to the subproject. It should be no problem... Sorry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.