Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting of authored commits #2672

Merged
merged 1 commit into from Mar 17, 2015

Conversation

tomasdeml
Copy link
Contributor

Adds highlighting of user's commits. This feature comes in handy (at least for me) when you are skimming through the commits while looking for something related to your work.

Commits are matched with current user's email address. The feature is enabled by default and can be configured in the 'Settings' dialog on the 'Colors' page. Commits are highlighted with LighYellow color by default.

revisiongraph
settings

@ghanique
Copy link

Nice!
On Feb 22, 2015 7:47 PM, "Tomáš Deml" notifications@github.com wrote:

Adds highlighting of user's commits. This feature comes in handy (at least
for me) when you are skimming through the commits while looking for
something related to your work.

Commits are matched with current user's email address. The feature is
enabled by default and can be configured in the 'Settings' dialog on the
'Colors' page. Commits are highlighted with LighYellow color by default.

[image: revisiongraph]
https://cloud.githubusercontent.com/assets/5622086/6319782/2de8872e-baca-11e4-8294-ccfee691d1b0.png
[image: settings]

https://cloud.githubusercontent.com/assets/5622086/6319817/56690b8c-bacb-11e4-8deb-4b713640403f.png

You can view, comment on, or merge this pull request online at:

#2672
Commit Summary

  • Highlighting of authored commits

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#2672.

@mnaoumov
Copy link
Contributor

+1

@jbialobr
Copy link
Member

jbialobr commented Mar 7, 2015

Nice! What would you say if we change it a little bit:

  1. When no revision is selected, then highlight the current user's revisions
  2. When there is a selected revision, then highlight revisions authored by the author of the selected revision.

@tomasdeml
Copy link
Contributor Author

That may make the feature more useful, hang on.

Adds highlighting of commits by author. Commits are matched with current user's email address (if no commit is selected) or with email of author of currently selected commit. The feature can be configured in the 'Settings' dialog on the 'Colors' page, commits are highlighted with LighYellow color by default.
@tomasdeml
Copy link
Contributor Author

@jbialobr I modified the feature according to your suggestions, it is certainly better now :).

One note about the implementation: I had to introduce a flag indicating an ongoing row count update (see DvcsGraph.cs) to prevent flickering of the selection right after a refresh of the revision grid. The SelectionChanged event is fired multiple times during the refresh because of multiple row count modifications. If you can think of more correct / elegant solution I'm more than eager to improve this part.

@jbialobr jbialobr merged commit 3ed5480 into gitextensions:master Mar 17, 2015
@jbialobr
Copy link
Member

@tomasdeml Well done, thanks!

@tomasdeml tomasdeml deleted the highlight-authored branch April 11, 2015 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants