Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormCreateBranch: Improve UX of CheckBox "Checkout after create" #6860

Merged
merged 1 commit into from Jun 26, 2019

Conversation

@mstv
Copy link
Member

commented Jun 25, 2019

Proposed changes

make all checkboxes of the form work the same standard way
by setting CheckBox.Text instead of a separate Label
in order to indicate the focus and to make the hotkey work directly

(I know this won't win a design price. Though I think it's not worth breaking the table layout and trying to align a left-labeled CheckBox under DPI scaling.)

Screenshots

Before

Checkout after create is focused:

grafik

After

grafik

Test methodology

  • manual

Test environment(s)

  • Git Extensions 3.2.0
  • Build 7b27300
  • Git 2.21.0.windows.1
  • Microsoft Windows NT 10.0.17763.0
  • .NET Framework 4.7.3416.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Jun 25, 2019
Copy link
Member

left a comment

I will improve whentranslation is updated.
Nice to see the check working!

in order to indicate focus and to make hotkey work directly
@mstv mstv force-pushed the mstv:fix/ux_create_branch_checkout branch from 7b27300 to ee843d8 Jun 26, 2019
@mstv

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

Ah, snap! But I did not change any text. Yes, moving counts, too...

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #6860 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6860      +/-   ##
==========================================
- Coverage   47.37%   47.37%   -0.01%     
==========================================
  Files         718      718              
  Lines       53546    53546              
  Branches     7054     7054              
==========================================
- Hits        25369    25366       -3     
- Misses      26790    26791       +1     
- Partials     1387     1389       +2
Flag Coverage Δ
#production 36.47% <ø> (-0.01%) ⬇️
#tests 97.68% <ø> (ø) ⬆️
@RussKie

This comment was marked as resolved.

Copy link
Member

commented Jun 26, 2019

@gitextensions gitextensions deleted a comment from codecov bot Jun 26, 2019
@RussKie

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Here's the issue I mentioned earlier - #6183

It looks like all checkbox controls have their labels to the right, so this dialog was the odd one.

@RussKie RussKie added this to the 3.2.0 milestone Jun 26, 2019
@mstv mstv merged commit a36468c into gitextensions:master Jun 26, 2019
3 checks passed
3 checks passed
CodeFactor No issues found.
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@mstv mstv deleted the mstv:fix/ux_create_branch_checkout branch Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.