Do not throw if process exits with 0 #9562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
approved these changes
Sep 9, 2021
- Ignore StandardError output - Use it only as exception text on non-zero exit code makes gitextensions#9056 less intercepting, fixes gitextensions#9462 Except for the actual changes in Executable.cs, this is just renaming the argument to match the changed functionality.
gerhardol
force-pushed
the
feature/mstv/fix/9462_exit_code_only
branch
from
69967a7
to
a678934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9462
Replaces #9489 (no changes at PR submit). @mstv has been missing a few weeks...
When approved, will rename the remaining throwOnErrorOutput arguments (that was added in #9056) after approval #9489 (comment)
See #9489 for further PR explanation
Proposed changes
Only throw on error exit, not on output in stderror.
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.