Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-completion: add git-prune into bash completion #667

Closed

Conversation

johnlinp
Copy link

@johnlinp johnlinp commented Jun 21, 2020

Sometimes git would suggest the user to run git prune when there are
too many unreachable loose objects. It's more user-friendly if we add
git-prune into bash completion.

Signed-off-by: John Lin johnlinp@gmail.com

Fixes #642.

Sometimes git would suggest the user to run `git prune` when there are
too many unreachable loose objects. It's more user-friendly if we add
git-prune into bash completion.

Signed-off-by: John Lin <johnlinp@gmail.com>
@johnlinp
Copy link
Author

johnlinp commented Jun 22, 2020

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 22, 2020

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 22, 2020

On the Git mailing list, Junio C Hamano wrote (reply to this):

"John Lin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: John Lin <johnlinp@gmail.com>
>
> Sometimes git would suggest the user to run `git prune` when there are
> too many unreachable loose objects. It's more user-friendly if we add
> git-prune into bash completion.

Yes, but it does not suggest all the time, and there is a reason.
Most of the time "gc" is more appropriate, but there are narrow
cases where "prune" is more appropriate and that is when the users
will see suggestion to run "prune".

Isn't it too much to type p-r-u-n-e while seeing that message,
typing as you read it?

I do not think it hurts to complete "git prune", in the sense that
we would want to avoid completing potentially destructive operation
to those who do not understand the implications, because the command
is pretty much benign.  But I am not sure it forces users to type
too many keystrokes too frequently that it requires a tab
completion.  I dunno.

Will queue for now.

Thanks.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 23, 2020

This branch is now known as jl/complete-git-prune.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 23, 2020

This patch series was integrated into pu via git@81c2a7a.

@gitgitgadget gitgitgadget bot added the pu label Jun 23, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Jun 24, 2020

This patch series was integrated into seen via git@d6ee617.

@gitgitgadget gitgitgadget bot added the seen label Jun 24, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Jun 24, 2020

This patch series was integrated into seen via git@5af2bf7.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 25, 2020

This patch series was integrated into seen via git@36bd151.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 25, 2020

This patch series was integrated into next via git@64f30b8.

@gitgitgadget gitgitgadget bot added the next label Jun 25, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Jun 29, 2020

This patch series was integrated into seen via git@a03ec38.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 2, 2020

This patch series was integrated into seen via git@7d338cb.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 7, 2020

This patch series was integrated into seen via git@65ffaca.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 7, 2020

This patch series was integrated into next via git@65ffaca.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 7, 2020

This patch series was integrated into master via git@65ffaca.

@gitgitgadget gitgitgadget bot added the master label Jul 7, 2020
@gitgitgadget gitgitgadget bot closed this Jul 7, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Jul 7, 2020

Closed via 65ffaca.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 10, 2020

On the Git mailing list, 林自均 wrote (reply to this):

Hi Junio,

I saw this integrated into master. Thanks.

Best,
John Lin

Junio C Hamano <gitster@pobox.com> 於 2020年6月23日 週二 上午2:28寫道:
>
> "John Lin via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: John Lin <johnlinp@gmail.com>
> >
> > Sometimes git would suggest the user to run `git prune` when there are
> > too many unreachable loose objects. It's more user-friendly if we add
> > git-prune into bash completion.
>
> Yes, but it does not suggest all the time, and there is a reason.
> Most of the time "gc" is more appropriate, but there are narrow
> cases where "prune" is more appropriate and that is when the users
> will see suggestion to run "prune".
>
> Isn't it too much to type p-r-u-n-e while seeing that message,
> typing as you read it?
>
> I do not think it hurts to complete "git prune", in the sense that
> we would want to avoid completing potentially destructive operation
> to those who do not understand the implications, because the command
> is pretty much benign.  But I am not sure it forces users to type
> too many keystrokes too frequently that it requires a tab
> completion.  I dunno.
>
> Will queue for now.
>
> Thanks.

@gitgitgadget
Copy link

gitgitgadget bot commented Jul 10, 2020

On the Git mailing list, Junio C Hamano wrote (reply to this):

林自均 <johnlinp@gmail.com> writes:

> Hi Junio,
>
> I saw this integrated into master. Thanks.

Thank you for writing the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant