Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes for TUIAccessibilityElement #73

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants

lukeman commented Sep 15, 2012

Somehow TUIAccessibilityElement was removed or never added to the Xcode project. Secondarily there was a syntax issue with a property. Both of these issues are fixed.

I only noticed this when updating the CocoaPods spec file as each version excludes this file to avoid a compiler error.

@lukeman lukeman referenced this pull request in CocoaPods/Specs Sep 15, 2012

Merged

add spec for TwUI 0.5.0 #509

Odd, I thought this was fixed ages ago on the original repo: twitter/twui@b44a6bf

lukeman commented Sep 16, 2012

Oh, interesting. I wonder if that means there are other commits that never made it back to this fork.

Even in the Twitter tree it looks like TUIAccessibilityElement never made it into the Xcode project.

Actually the class itself is just a stub. There's no use for it and as a result it is not used at all.

I'm pretty sure we can remove it-- the whole TwUI accessibility stuff is a mess at the moment.

CodaFi commented Sep 16, 2012

@galaxas0 If you feel like that, then remove it, fix what breaks, then submit a pull request. A little less talk, and a little more action!! :)

@CodaFi Ahh, yeahh =___= I've got a lot of talk to work on. I'm still working on some standard controls and things to add to TwUI-- especially that navigation system I was talking about. I'll just pop in a commit for this. Expect something next week? :D

I haven't looked too much into the accessibility stuff that's already implemented in TwUI, but I agree with @jwilling and @galaxas0 that this class seems not to be used at all and therefore should be removed.

I'd rather do that than keep around a useless stub.

github#74 <-- here you go! I've also renamed the example project folder to something simpler. But no other changes yet.

This can be closed due to commit a482226.

@jspahrsummers jspahrsummers removed their assignment May 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment