New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

since_tag doesn't work when tag specified is the latest tag #555

Closed
alexjfisher opened this Issue Aug 25, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@alexjfisher

alexjfisher commented Aug 25, 2017

If since_tag is the latest tag available, the unreleased section contains all PRs/issues (not just the ones since the date of the since_tag).

@Crunch09

This comment has been minimized.

Contributor

Crunch09 commented Oct 3, 2017

Hey,
haven't contributed to this project yet but happy to look into this bug if no one has started work on this yet.

Crunch09 added a commit to Crunch09/github-changelog-generator that referenced this issue Oct 4, 2017

filter tags correctly when `since_tag` is set to most recent tag
Before this fix [`filtered_tags`](https://github.com/skywinder/github-changelog-generator/blob/master/lib/github_changelog_generator/generator/generator_generation.rb#L132)
was empty which caused a fallback to the last tag in the sorted_tags array (which is the oldest tag).
There for no issues and PRs were filtered in that case.

fixes github-changelog-generator#555
fixes github-changelog-generator#304

olleolleolle added a commit that referenced this issue Oct 5, 2017

filter tags correctly when `since_tag` is set to most recent tag (#566)
* filter tags correctly when `since_tag` is set to most recent tag
Before this fix [`filtered_tags`](https://github.com/skywinder/github-changelog-generator/blob/master/lib/github_changelog_generator/generator/generator_generation.rb#L132)
was empty which caused a fallback to the last tag in the sorted_tags array (which is the oldest tag).
There for no issues and PRs were filtered in that case.

fixes #555
fixes #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment