New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrettyPrint class is included using lowercase 'pp' #43

Merged
merged 1 commit into from Jan 15, 2015

Conversation

Projects
None yet
2 participants
@schwing
Contributor

schwing commented Jan 14, 2015

PrettyPrint should be required using lowercase 'pp' rather than capital 'PP' to function correctly on case-sensitive filesystems. http://ruby-doc.org/stdlib-2.1.0/libdoc/pp/rdoc/PP.html#method-c-pp

This is a fix for:

$ github_changelog_generator
.rbenv/versions/2.1.2/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- PP (LoadError)
@skywinder

This comment has been minimized.

Show comment
Hide comment
@skywinder

skywinder Jan 15, 2015

Member

Thanks! 👍

Member

skywinder commented Jan 15, 2015

Thanks! 👍

skywinder added a commit that referenced this pull request Jan 15, 2015

Merge pull request #43 from schwing/prettyprint
PrettyPrint class is included using lowercase 'pp'

@skywinder skywinder merged commit de6763a into github-changelog-generator:master Jan 15, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@skywinder skywinder added the bug label Jan 15, 2015

@skywinder

This comment has been minimized.

Show comment
Hide comment
@skywinder

skywinder Jan 15, 2015

Member

You can find your reference to your pull-request in updated changelog file :)

Member

skywinder commented Jan 15, 2015

You can find your reference to your pull-request in updated changelog file :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment