Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gitignore #836

Merged
merged 4 commits into from May 18, 2020
Merged

fix gitignore #836

merged 4 commits into from May 18, 2020

Conversation

skywinder
Copy link
Member

@skywinder skywinder commented May 8, 2020 •
edited

  • put back .lock files to be able to make reproducible builds
  • remove .idea from gitignore (it should be ignored globally by the developer and not related to the project)

@skywinder skywinder changed the title fix gitignore put back .lock files to be able to make reproducible builds + remove .idea from gitignore (it should be ignored globally by the developer and not related to the project) fix gitignore May 8, 2020
@weekly-digest weekly-digest bot mentioned this pull request May 10, 2020
Closed
olleolleolle
olleolleolle approved these changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reasonable change!

@skywinder skywinder merged commit e27861b into master May 18, 2020
@skywinder skywinder deleted the fix-ignore-file branch May 18, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skywinder @olleolleolle