fix: fix time to first response#97
Merged
zkoppert merged 2 commits intoAug 7, 2023
Merged
Conversation
Collaborator
|
Thanks for catching and fixing this! I think this bug was introduced when we went from only requesting 1 comment to multiple. I'll work on creating a test to catch this so it doesn't sneak through again in the future. |
zkoppert
approved these changes
Aug 7, 2023
Collaborator
zkoppert
left a comment
zkoppert
left a comment
There was a problem hiding this comment.
🎉 I will merge and publish a release later today.
Signed-off-by: Zack Koppert <zkoppert@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now time to first response on issues is calculated incorrectly as
first_review_comment_timeandfirst_review_comment_timeare being overwritten by data from later comments.