Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

added personal details: sharanp98 #1291

Closed

Conversation

sharanp98
Copy link
Contributor

@sharanp98 sharanp98 commented May 20, 2020

Application to the Class of 2020🎓

This pull request template helps you complete an application to the Class of 2020. Use the checklist below to verify you have followed the instructions correctly.

Checklist ✅

  • I have read the instructions on the README file before submitting my application.
  • I made my submission by creating a folder on the _data folder and followed the naming convention mentioned in the instructions (<username>), added my profile picture and markdown file.
  • I have used the Markdown file template to add my information to the Year Book.
  • I have completed the form: https://airtable.com/shrmuHxu38ZariKJi
  • My application belongs to:
    • Tier 1 📖: I added myself to the Year Book.
    • Tier 2 ✏️: I wrote a post on DEV about a project I built.
    • Tier 3 ✨: I want my project to be highlighted on stream.
  • I understand that a reviewer will merge my pull request after examining it or ask for changes in case needed.
  • I understand I should not tag or add a reviewer to this Pull Request.
  • I understand the photo added to the template will be used in the ceremony "Graduate Walk".
  • I have added the event to my Calendar.

@sharanp98 sharanp98 closed this May 20, 2020
@sharanp98 sharanp98 reopened this May 20, 2020
Copy link
Contributor

@juanpflores juanpflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have reviewed 📝 your application to the yearbook. It looks great ✨ but we found that your profile picture doesn't have the minimum size. It should be at least 544x544 pixels but it is 400.0x400.0 px. I will close this PR so you can do the changes requested. You can open a new one once you've done the fixes and we will review it again.😊

@sharanp98
Copy link
Contributor Author

I will open another PR but will I still be eligible for Tier 2 and Tier 3 swag? I had already opened the PR in time but the minor error was with the size of the image.

@sharanp98
Copy link
Contributor Author

I had submitted a PR that was eligible for Tier 2 but it was closed due to the profile picture not meeting the size criterion. I have opened another PR and submitted another form but am I still eligible for the Tier 2 rewards?
This was my original PR - #1291
My modified PR - #3073

The PR was closed only a few hours ago by the Github team. I immediately opened another PR but the README now states new PRs are no longer eligible for Tier 2. Please help.

elisemoe pushed a commit that referenced this pull request May 25, 2020
* added personal details: sharanp98

* Change image size

544x 544

* Delete sharan.jpg

* Update sharanp98.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants