Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jitsi videocall route #41

Merged
merged 3 commits into from Jul 27, 2020
Merged

Add Jitsi videocall route #41

merged 3 commits into from Jul 27, 2020

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 27, 2020

This pull request adds a video call route to the frontend.

Screenshot showing video embed UI

To create a new video call for a tutoring session, simply provide a link to https://githubexpertsui.z21.web.core.windows.net/#/videocall/${ROOM_NAME} to both parties. Note that the ROOM_NAME should be unique and hard to guess as we don't have authentication in front of this route.

When the video call is finished (i.e., both parties hang up) we make a request to the notify the API server of this event, specifically a POST request is made to https://githubexpertsapi.azurewebsites.net/api/calldone with body { "roomName": ${ROOM_NAME} } so that the server can process the payment to the tutor associated with the video call session.

Resolves #20.
Resolves #22.
Resolves #30.

@c-w c-w requested review from steverhall and alexgolesh and removed request for steverhall and alexgolesh Jul 27, 2020
@c-w
Copy link
Contributor Author

c-w commented Jul 27, 2020

@steverhall Please review and confirm that this integration with the backend API is fine by you.

@c-w
Copy link
Contributor Author

c-w commented Jul 27, 2020

@jeongl Please take a look at this pull request so that you're aware of the staring point of the UI we put together. I would imagine that the remaining UI components for scheduling/etc. would hook into this same framework.

@jeongl
Copy link
Contributor

jeongl commented Jul 27, 2020

@c-w Could you possibly modify index.css and rename it to index.scss? The primer UI library uses sass modules. Here's the package to install for create-react-app. https://create-react-app.dev/docs/adding-a-sass-stylesheet/

You'd also need this import at the start of the new index.scss file - @import "@primer/css/index.scss"

github-experts-ui/src/index.css Outdated Show resolved Hide resolved
jeongl
jeongl approved these changes Jul 27, 2020
@c-w c-w merged commit a69414a into master Jul 27, 2020
2 checks passed
@c-w c-w deleted the videocall branch Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment