Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video call UI #58

Merged
merged 1 commit into from Jul 28, 2020
Merged

Fix video call UI #58

merged 1 commit into from Jul 28, 2020

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 27, 2020

The video call iframe was pushed off the screen in #55 as the new CSS makes the (perfectly reasonable) assumption that all the code is nested under the React root. As such, this pull request moves the iframe under the React root.

Screenshot showing correctly nested video call iframe

@c-w c-w requested a review from jeongl Jul 27, 2020
@c-w
Copy link
Contributor Author

c-w commented Jul 27, 2020

Reported by @alexgolesh

jeongl
jeongl approved these changes Jul 28, 2020
@c-w c-w merged commit 9205a17 into master Jul 28, 2020
2 checks passed
@c-w c-w deleted the fix-video-call branch Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants