New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index.lock prevents git operations #125

Closed
guitarrapc opened this Issue Jul 12, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@guitarrapc

guitarrapc commented Jul 12, 2017

Prerequisites

No %LOCALAPPDATA%\GitHubUnity\github-unity.log logs found.

Description

Github for Unity will create index.lock for not managed file and will prevent itself and other Git tool from Commit/Push and others.

Steps to Reproduce

  1. Clone any repo which include Github for Unity. (Or install Github for Unity)
  2. Make Unity path under any directory, like REPONAME\Hoge.Unity(Unity Assets)
  3. Create any git tracking file right under repo, like REPONAME\test.txt
  4. Open Unity and show Github for Unity Window.
  5. Select Changed, History, Branches or any tabs for many time. Sometime index.lock is created and never removed, I think there are some race condition that I could not reproduce with simple way.
  6. All git tools are locked include Github for Unity

At stage 4 there are no index.lock file.

image

At stage 5 there are index.lock file and will never remove until close Unity itself.

image

Expected behavior: [What you expect to happen]

index.lock file should immediately removed after index is required. Do not place it permanently until App lifetime.

Actual behavior: [What actually happens]

index.lock will remain while Unity is running.

Reproduces how often: [What percentage of the time does it reproduce?]

1st time to import Github for Unity unitypackage into Unity.

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

@StanleyGoldman StanleyGoldman added the bug label Jul 12, 2017

@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Jul 12, 2017

Member

Thanks for the bug report, I will look to reproduce it.

Member

StanleyGoldman commented Jul 12, 2017

Thanks for the bug report, I will look to reproduce it.

@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Aug 9, 2017

Member

Hey @guitarrapc. I think your issue will be near impossible to reproduce consistently, but I do believe it is resolved. In the previous build some events were triggering git operations very often and too quickly. In the latest build this is much more under control and future builds should continue this trend.

Try out the new build and let me know how it works for you. I'm going to close this issue, but if you see this happen again, don't hesitate to open it back up.

Member

StanleyGoldman commented Aug 9, 2017

Hey @guitarrapc. I think your issue will be near impossible to reproduce consistently, but I do believe it is resolved. In the previous build some events were triggering git operations very often and too quickly. In the latest build this is much more under control and future builds should continue this trend.

Try out the new build and let me know how it works for you. I'm going to close this issue, but if you see this happen again, don't hesitate to open it back up.

@guitarrapc

This comment has been minimized.

Show comment
Hide comment
@guitarrapc

guitarrapc commented Aug 9, 2017

Thank you @StanleyGoldman !

@shana shana changed the title from Index.lock created and will prevent git operation to Index.lock prevents git operations Aug 22, 2017

@StanleyGoldman StanleyGoldman added this to the 0.18 milestone Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment