Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add .editorconfig to ease contribution to the project #248
I agree, an
I always forget that
Feel free to take this on if you like.
Was looking at #350 and it seems it is on hold and the repository deleted. Having some experience with editorconfig files I hope to help clear up some confusion and start some discussion.
From the website:
From what I can tell, this projects styleguide most of these rules would fall into the linter category, which I think is beyond the scope of EditorConfig.
However those rules may be specific to VS2017. I suspect many developers will use that as its Unity's default, but I wonder about other editors support, and if maintaining these rules is worth the effort for something that is meant to make things simple and consistent. I would assume that many editor's will support the c# solution, so this list should be improved / tested against other editors instead of using single editor specific properties.
I would propose we take a simpler approach to editorconfig like so
Hey @Frozenfire92 thanks for participating.
Yea, I think a large part of the problem in #350 was that it was a bit too much too soon. (I just closed that pull request.) It seemed like the pull request was attempting to add a large template without regard to the code styles we value in this project.
The other part of the problem is there would not be a uniform way of applying the editor styles in both Visual Studio 2015 and Visual Studio 2017.
Something that you proposed that should work a bit more universally would be appreciated. If you want to put that in a pull request I can see about getting that merged in.
After finally going to do this I noticed its already in the project
Unless the two options I proposed above are desired this could likely be closed