Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix garbled characters in history view with non-ascii characters (fixes#124) #136
I replaced the reading of standard output from asynchronous to synchronous to eliminate garbled characters.
Synchronous reading of both standard output and standard error may cause deadlock. So I replaced standard output only.
Also, I'm worried about whether performance will be bad.
Hey @shiena, sorry it's taken so long to get to this.
Processes are executed in a separate thread, so because of the bug in Unity we can definitely go with synchronous calls here. Also until Unity removes support for their .net 3.5 profile we will not compile this library in .net 4.6.
So when you get the chance remove all the
I understand what happened now, you worked real hard to keep both async and sync methods possible. Since we are going to go sync, you can rewrite the way the output is being handled to be simpler & easier to follow.
@shiena there is another branch based off this, could you test it out for me.
referenced this pull request
Aug 11, 2017
Even if you need the git command line option, this pull request is redundant, so I would like to create another pull request.