From 352ec598ad591079e2321456050df28d086696eb Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Mon, 16 Apr 2018 17:41:54 -0400 Subject: [PATCH 1/2] Allowing guids to be populated correctly Instead of a dictionary as in the Changes view. Here `guids` is used as a positional marker in the entries array. It should be populated with all entries regardless if they are assets or not. --- .../GitHub.Unity/UI/ProjectWindowInterface.cs | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs index c342f93b3..340992c0d 100644 --- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs +++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs @@ -183,25 +183,9 @@ private static void OnStatusUpdate() guids.Clear(); for (var index = 0; index < entries.Count; ++index) { - var gitStatusEntry = entries[index]; - - var path = gitStatusEntry.ProjectPath; - if (gitStatusEntry.Status == GitFileStatus.Ignored) - { - continue; - } - - if (!path.StartsWith("Assets", StringComparison.CurrentCultureIgnoreCase)) - { - continue; - } - - if (path.EndsWith(".meta", StringComparison.CurrentCultureIgnoreCase)) - { - continue; - } - + var path = entries[index].ProjectPath; var guid = AssetDatabase.AssetPathToGUID(path); + guids.Add(guid); } From 488512e3fc3be6be01132232727444c39d0ac7d8 Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Wed, 18 Apr 2018 09:57:48 -0400 Subject: [PATCH 2/2] Removing space --- .../Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs index 340992c0d..d79cb1a95 100644 --- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs +++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs @@ -185,7 +185,6 @@ private static void OnStatusUpdate() { var path = entries[index].ProjectPath; var guid = AssetDatabase.AssetPathToGUID(path); - guids.Add(guid); }