Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Perl 6 Syntax highlighter has changed repo URL's and is now an official Perl 6 Org project #3377

Merged
merged 5 commits into from Dec 23, 2016

Conversation

samcv
Copy link
Contributor

@samcv samcv commented Dec 10, 2016

Update the URL's and add the repo. Let me know if I did this right.

@samcv samcv changed the title The Perl 6 Syntax highlighter has changed repo URL's as is now an official Perl 6 Org project The Perl 6 Syntax highlighter has changed repo URL's and is now an official Perl 6 Org project Dec 11, 2016
@pchaigno
Copy link
Contributor

Hm. The old repository doesn't make any mention of the new location and the last commit is from only 9 days ago. Will development continue on the "old" repository? Was there any bug fixes or improvements from the old to the new?

/cc @MadcapJake

@samcv
Copy link
Contributor Author

samcv commented Dec 11, 2016

Yes there have been improvements:
https://github.com/perl6/atom-language-perl6/blob/master/CHANGELOG.md#v195

There are a huge number of improvements from 1.8 (that old repo) and the new one at 1.9.5

Edit: Development won't continue at the old repository.

@zoffixznet
Copy link

zoffixznet commented Dec 14, 2016

To shed more light on the situation and to better answer @pchaigno question and perhaps better explain to @MadcapJake what's happening, if they ever happen to reappear.

  1. @MadcapJake is the original developer of the perl6fe atom extension and the code that GitHub currently uses to highlight its Perl 6 gists and code. The community thanks @MadcapJake for that work, as outside of vim, this is currently the only way to get syntax highlighting for Perl 6 that's worth two bits.
  2. Somewhere around middle of June 2016, @MadcapJake stopped responding to Issues on the repository, and so the problems stayed unfixed and the repository also accumulated a couple of PRs that remained unmerged
  3. 5 months later, around the middle of November, @samcv started participating in the Perl 6 community, and unaware of @MadcapJake prolonged absence, started fixing the issues in the repository and creating PRs. Before the creation of the https://github.com/perl6/atom-language-perl6 fork, she created 99 commits to the repo, fixing numerous issues
  4. As a watcher of @MadcapJake's repo, I was receiving several notifications daily due to @samcv's work, so on November 22nd, 2016, I tracked down @MadcapJakes' Twitter account and asked them to review the PRs accumulating in the repo as well as to give out commit bits so members of community could make updates.
  5. 6 days later, on November 28, 2016, @MadcapJake responded, saying they've been busy and will merge PRs and hand out commit bits that same evening.
  6. 3 days later, on December 1, 2016, @MadcapJake indeed did have some activity and merged a couple of PRs along with releasing version 1.8.0 of the Atom plugin. This is the activity @pchaigno pointed out, however, it was just a couple of commits over the past half a year. I'm unaware of anyone receiving commit bits during that period.
  7. @MadcapJake's brief reappearance inspired @samcv to fix a whole ton of Issues and make a PR that at the time of this writing still remains unmerged.
  8. On December 2, 2016, @MadcapJake commented on that PR commending the work and promising to merge the PR within the next 10 hours.
  9. 4 days later, on December 6, 2016, I commented on the PR, imploring @MadcapJake to merge it
  10. 4 days later, on December 10, 2016, seeing @MadcapJake is again being non-responsive, we forked @MadcapJake's repo into perl6 org (the official org of the Perl 6 language), and applied all 144 of unmerged @samcv's commits.

So whether @MadcapJake will continue development of their fork is unknown to us. However, the perl6 org has 263 members, as opposed to a single developer, and so it'd be a bit harder for it to bit rot. Currently, it's ~144 commits ahead of @MadcapJake's version, fixing numerous issues, which makes it more correct, and more suitable for use by GitHub to highlight its gists and perl 6 code.

Please merge this. Thanks.

EDIT: It's worth pointing out @MadcapJake is also a member of the perl6 org, enjoying the same full access to the repository of perl6 org's fork as @samcv

@samcv
Copy link
Contributor Author

samcv commented Dec 14, 2016

Wow, that is pretty detailed, thanks for putting that together @zoffixznet
+1

@samcv
Copy link
Contributor Author

samcv commented Dec 14, 2016

Also to note, development continues at a rapid pace. v1.9.8 just got released as well.

The language now has a /spec folder for spec tests as well as having automated what was 1/4 of the code.

If @MadcapJake sees this, thanks for all the work you put into the project.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed explanation @zoffixznet!
I think we're 👍 to good.
We'll just need approval from one of GitHub's maintainers before merging this.

@pchaigno
Copy link
Contributor

@samcv Could you update the branch before we merge?

@samcv
Copy link
Contributor Author

samcv commented Dec 23, 2016

@pchaigno I have resolved the merge conflicts now.

@samcv
Copy link
Contributor Author

samcv commented Dec 23, 2016

Or did you want me to update the references too?

@pchaigno pchaigno merged commit 08b63e7 into github-linguist:master Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants