Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a newer SourcePawn grammar #4557

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

X6B0ISI09wD4
Copy link
Contributor

Description

As discussed in #3156, a more up-to-date grammar would be ideal for SourcePawn. The syntax has changed significantly since the last changes to the currently used grammar.

Checklist:

  • I am changing the source of a syntax highlighting grammar

@X6B0ISI09wD4
Copy link
Contributor Author

Does the current contributing documentation mention having to run script/list-grammars and ensuring the TextMate scope selector is still correct? Not sure if I missed either of those.

@lildude
Copy link
Member

lildude commented Jul 16, 2019

Does the current contributing documentation mention having to run script/list-grammars and ensuring the TextMate scope selector is still correct? Not sure if I missed either of those.

Nope, because it is called by add-grammar which is documented as the method to use to add or replace a grammar.

@lildude lildude requested review from pchaigno and Alhadis July 16, 2019 09:48
@Alhadis
Copy link
Collaborator

Alhadis commented Jul 18, 2019

/cc our friendly local Pawn expert, @50Wliu. Let us know if this grammar's carrying any red flags.

EDIT: I hate mobile keyboards.

@lildude lildude merged commit 9088eb8 into github-linguist:master Aug 12, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants