Remove repo.remove (or fix it, if it's still useful) #108

Closed
Pomax opened this Issue Mar 5, 2014 · 7 comments

Comments

Projects
None yet
5 participants

Pomax commented Mar 5, 2014

when I call the .remove() function, I keep getting these errors:

POST https://api.github.com/repos/Pomax/gh-blog/git/trees?1393981519258 422 (Unprocessable Entity) api.github.com/repos/Pomax/gh-blog/git/trees?1393981519258:1
POST https://api.github.com/repos/Pomax/gh-blog/git/commits?1393981519451 422 (Unprocessable Entity) api.github.com/repos/Pomax/gh-blog/git/commits?1393981519451:1
Uncaught TypeError: Cannot read property 'sha' of undefined 

The network responses for the failed URLs are

{
  "message": "Must supply tree.sha or tree.content",
  "documentation_url": "http://developer.github.com/v3/git/trees/#create-a-tree"
}

and

{
  "message": "Validation Failed",
  "documentation_url": "http://developer.github.com/v3/git/commits/#create-a-commit",
  "errors": [
    {
      "value": null,
      "resource": "Commit",
      "field": "tree",
      "code": "missing"
    }
  ]
}

respectively.

w35l3y commented May 21, 2014

👆

Was it fixed already ? Because it is clearly deleting ref.sha in the code.

Remove does not work for me either, but delete() seems to. Perhaps the REAME needs to be updated?

Remove() or Delete() doesn't work for me. They actually behave the same and give me the same error "Uncaught SyntaxError: Unexpected number" in the browser when calling this method. Any update on this? Would really appreciated.

Owner

aendrew commented Apr 6, 2015

Huh. I just opened #175, given I ran into repo.remove and repo.delete while improving test coverage. Do we need both of these? Or will one working "remove a file or blob from a repo" function suffice? If so, which should it be called, and should the other be preserved in some capacity for backwards compatibility?

aendrew added the bug label Apr 6, 2015

aendrew changed the title from .remove does not seem to work to Remove repo.remove (or fix it, if it's still useful) Oct 17, 2015

aendrew added this to the v0.10.7 milestone Oct 17, 2015

aendrew self-assigned this Oct 17, 2015

Owner

aendrew commented Oct 17, 2015

This thing generates so many issues and I want it fixed yesterday. Giving it P1 for next release.

@aendrew aendrew modified the milestone: v0.10.8, v0.10.7 Oct 30, 2015

Owner

aendrew commented Oct 30, 2015

This is fixed by c895f35.

aendrew closed this Oct 30, 2015

Owner

aendrew commented Oct 30, 2015

For future reference, I ended up removing repo.delete (did the exact same thing as repo.remove but was an uglier implementation) and aliased it to repo.remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment