This repository has been archived by the owner. It is now read-only.

Fixed allowing focus in text field in Popover #65

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@falkobuttler

No description provided.

@@ -97,6 +97,11 @@ - (BOOL)isKeyWindow {
return YES;
}
+- (BOOL)canBecomeKeyWindow
+{

This comment has been minimized.

Show comment Hide comment
@jspahrsummers

jspahrsummers Feb 10, 2013

Contributor
@@ -97,6 +97,11 @@ - (BOOL)isKeyWindow {
return YES;
}
+- (BOOL)canBecomeKeyWindow
+{
+ return YES;

This comment has been minimized.

Show comment Hide comment
@jspahrsummers

jspahrsummers Feb 10, 2013

Contributor

Can you please indent this with tabs instead of spaces?

@jspahrsummers

jspahrsummers Feb 10, 2013

Contributor

Can you please indent this with tabs instead of spaces?

@jspahrsummers

This comment has been minimized.

Show comment Hide comment
@jspahrsummers

jspahrsummers Feb 10, 2013

Contributor

Thanks! I've added some style notes.

Assigning to @dannygreg.

Contributor

jspahrsummers commented Feb 10, 2013

Thanks! I've added some style notes.

Assigning to @dannygreg.

@ghost ghost assigned dannygreg Feb 10, 2013

@dannygreg

This comment has been minimized.

Show comment Hide comment
@dannygreg

dannygreg Feb 11, 2013

If we make this change then we should remove the -isKeyWindow override (which currently just returns YES), also the comment above the declaration of RBLPopoverWindow.

That said, this is definitely a fix, if you want focused text fields within popovers, although it is a breaking change.

Fix up the style, and my comments above and this is good to merge 👍.

If we make this change then we should remove the -isKeyWindow override (which currently just returns YES), also the comment above the declaration of RBLPopoverWindow.

That said, this is definitely a fix, if you want focused text fields within popovers, although it is a breaking change.

Fix up the style, and my comments above and this is good to merge 👍.

dannygreg pushed a commit that referenced this pull request Apr 2, 2013

Danny Greg
Merge pull request #76 from atomkirk/master
Finishing what was started with #65

@dannygreg dannygreg closed this Apr 2, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.