New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right hand of PR file diff sometimes comes up empty #1006

Closed
jcansdale opened this Issue Jun 6, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@jcansdale
Contributor

jcansdale commented Jun 6, 2017

  • GitHub Extension for Visual Studio version: 2.2.1.100 (dev)
  • Visual Studio version: 2015

What happened (with steps, logs and screenshots, if possible)

I opened a PR without checking it out and double clicked on a file.

image

The right hand file came up as empty (deleted?). All other files in this PR appeared the same.

I later had some issues with Git moving between branches, which might be related. git reset --hard did however seem to fix it. Unfortunately I don't have a consistent repro for this. 😕

@jcansdale jcansdale added the bug label Jun 6, 2017

@jcansdale jcansdale self-assigned this Jun 6, 2017

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Jun 6, 2017

Contributor

It's doing it again and I've got the debugger attached this time. 😄

This task will return null:
image

Resulting in this:

image

Contributor

jcansdale commented Jun 6, 2017

It's doing it again and I've got the debugger attached this time. 😄

This task will return null:
image

Resulting in this:

image

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Jun 6, 2017

Contributor

It seems it can't find the commit. 😕

image

The commit is: 6949a59c18e391deddaf58456a1d23131d308ded.

From the command line:

> git log 6949a59c18e391deddaf58456a1d23131d308ded
fatal: bad object 6949a59c18e391deddaf58456a1d23131d308ded

The repo is: github.com/nunit/nunit

Contributor

jcansdale commented Jun 6, 2017

It seems it can't find the commit. 😕

image

The commit is: 6949a59c18e391deddaf58456a1d23131d308ded.

From the command line:

> git log 6949a59c18e391deddaf58456a1d23131d308ded
fatal: bad object 6949a59c18e391deddaf58456a1d23131d308ded

The repo is: github.com/nunit/nunit

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Jun 7, 2017

Contributor

This was happening when viewing a file from a branch what wasn't already in the local repro. This explains why checking out a PR fixed it and make it difficult to repro!

Fixed by d4ed727...7559733

Contributor

jcansdale commented Jun 7, 2017

This was happening when viewing a file from a branch what wasn't already in the local repro. This explains why checking out a PR fixed it and make it difficult to repro!

Fixed by d4ed727...7559733

@jcansdale jcansdale closed this Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment