New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path field doesn't have default cloning path of C:\Users\[user]\Source\Repos #107

Closed
amytruong opened this Issue Sep 30, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@amytruong

Steps to reproduce:

  1. Click on Clone action link
    Expected Results: Path field contains default cloning path C:\Users[user]\Source\Repos
    Actual Results: Mine displays the VM path. However is this just me b/c I'm VM?

Will take a look on a windows machine to confirm.
screen shot 2015-09-30 at 2 12 52 pm

@jakubsuchybio

This comment has been minimized.

Show comment
Hide comment
@jakubsuchybio

jakubsuchybio Oct 25, 2015

I have the same problem.
It displays default location for user's "...\Documents\GitHubVisualStudio" folder every time.
Expected result should be location used in:
Team Explorer -> Home -> Settings -> Git -> Global settings -> Default Repository Location

Edit:
I made some digging and found the problem, but I don't know where to get Git Global Settings values for completing pull request.

In Github.App project Services.RepositoryCloneService.cs:33 is call for
GetUserDocumentsPathForApplication() which i belive calls for
Extensions.EnvironmentExtensios.cs:24 where is Path.Combine("users Documents path", "GitHubVisualStudio")
There should be code for getting Global settings value for Default Repository Location

I have the same problem.
It displays default location for user's "...\Documents\GitHubVisualStudio" folder every time.
Expected result should be location used in:
Team Explorer -> Home -> Settings -> Git -> Global settings -> Default Repository Location

Edit:
I made some digging and found the problem, but I don't know where to get Git Global Settings values for completing pull request.

In Github.App project Services.RepositoryCloneService.cs:33 is call for
GetUserDocumentsPathForApplication() which i belive calls for
Extensions.EnvironmentExtensios.cs:24 where is Path.Combine("users Documents path", "GitHubVisualStudio")
There should be code for getting Global settings value for Default Repository Location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment