New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub pane asks to sign in but Connect To GitHub dialog disables GitHub login #1094

Closed
grokys opened this Issue Jul 31, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@grokys
Contributor

grokys commented Jul 31, 2017

I've got into a state where the GitHub pane is asking me to login:

image

But when i click the "Sign in" link the GitHub tab is disabled and I can only sign into enterprise:

image

This seems to be happening because I have valid credentials in the credential store, but a connection is not present in the ghfvs.connections file.

We need to make these two places where connection information is stored aware of each other.

@grokys grokys added the bug label Jul 31, 2017

@grokys grokys referenced this issue Jul 31, 2017

Open

Refactor login process #809

3 of 6 tasks complete
@grokys

This comment has been minimized.

Contributor

grokys commented Aug 17, 2017

To repro:

  1. Sign in to .com
  2. Close VS
  3. Delete the ghfvs.connections file from C:\Users\grokys\AppData\Local\GìtHubVisualStudio
  4. Reopen VS
  5. Try to sign into .com

Workaround until this is fixed:

  1. Open Credential Manager from the Windows Start Menu
  2. Delete all "Generic Credentials" that mention "github"
@jcansdale

This comment has been minimized.

Contributor

jcansdale commented Oct 5, 2017

I've had a report of this fix working for a user who couldn't log into GitHub Enterprise. They followed the following instructions:

  • Open Credential Manager from the Windows Start Menu
  • Click on Windows Credentials
  • Select the credentials related to your Enterprise server
  • Click on Remove

@meaghanlewis meaghanlewis added this to Medium Priority in BUGS Dec 2, 2017

@grokys

This comment has been minimized.

Contributor

grokys commented Dec 11, 2017

This should have been fixed in #1277 and will be shipped in the next minor version.

@grokys grokys closed this Dec 11, 2017

BUGS automation moved this from Medium Priority to Done Dec 11, 2017

@grokys grokys referenced this issue Dec 11, 2017

Merged

Master PR for refactoring connections #1277

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment