New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't comment on PR from parent repo from fork #1195

Closed
jcansdale opened this Issue Aug 24, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@jcansdale
Contributor

jcansdale commented Aug 24, 2017

  • GitHub Extension for Visual Studio version: 2.3.0.24 (published)
  • Visual Studio version: 2015/2017
  1. Opened a solution in a forked repo jcansdale/PullRequestSandbox.
  2. Selected a PR in list of PRs from parent repo
  3. Opened a PR file (diff view appeared)
  4. Tried to add inline comment to file
  5. When I clicked Comment button Not Found appeared

image

It looks like it's trying to publish the comment to a PR on the forked repo.

image

grokys added a commit that referenced this issue Aug 25, 2017

Post comments to correct repo when on a fork.
If the user had a forked repo checked out and was viewing the parent repo's PRs, posting a comment was erroneously trying to post the comment to the _fork_ repo, resulting in a "Not Found" exception.

Fixes #1195.

@jcansdale jcansdale closed this in #1198 Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment