New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always asked to sign out and back in to create gist #1201

Closed
grokys opened this Issue Aug 25, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@grokys
Contributor

grokys commented Aug 25, 2017

  • GitHub Extension for Visual Studio version: 2.3.0.24
  • Visual Studio version: 2015

When I go to create a gist, I am prompted to sign out and back in:

image

I can then create the gist, but if I exit the dialog and try to create a gist again, I'm prompted to sign out and back in again.

The "sign out and back in" workflow was needed for an old version where a user may be logged in with the wrong scopes. This functionality can be taken out now.

@grokys grokys added the bug label Aug 25, 2017

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Aug 25, 2017

Collaborator

@grokys Agree that we probably don't need the check anymore, but why is it suddenly broken?

Collaborator

shana commented Aug 25, 2017

@grokys Agree that we probably don't need the check anymore, but why is it suddenly broken?

grokys added a commit that referenced this issue Aug 28, 2017

Removed LogoutRequired flow for Gists.
This was only required when upgrading from very old versions of GHfVS, and was recently broken, causing the "Logout Required" view to be shown to the user every time they tried to create a gist.

Fixes #1201

@shana shana closed this in #1203 Aug 29, 2017

@grokys grokys changed the title from Always asked to sign out and back in to create gitst to Always asked to sign out and back in to create gist Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment