New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid origin url crashes Visual Studio #121

Closed
rcorre opened this Issue Oct 8, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@rcorre

rcorre commented Oct 8, 2015

  1. Install the Github extension (1.0.14.0) on VS 2015
  2. Add a remote 'origin' with url 'asdf'
  3. Watch the fireworks

Any further attempts to connect to that repo will crash Visual Studio.
If you restart Visual Studio, it will remain connected, and opening Team Explorer will cause a crash.

Relevant parts of the call stack:

System.dll!System.Uri.CreateThis(string uri, bool dontEscape, System.UriKind uriKind) Line 49
System.dll!System.Uri.Uri(string uriString) Line 400
System.dll!System.UriBuilder.Uri.get() Line 320
GitHub.Exports.dll!GitHub.Primitives.UriString.ToRepositoryUrl()    
GitHub.Exports.dll!GitHub.VisualStudio.Services.GetUri(LibGit2Sharp.Repository repo)    
GitHub.VisualStudio.dll!GitHub.VisualStudio.Base.TeamExplorerItemBase.RepoChanged() 
GitHub.VisualStudio.dll!GitHub.VisualStudio.Base.TeamExplorerNavigationItemBase.UpdateRepo(Microsoft.VisualStudio.TeamFoundation.Git.Extensibility.IGitRepositoryInfo repo) 
GitHub.VisualStudio.dll!GitHub.VisualStudio.Base.TeamExplorerServiceHolder.NotifyActiveRepo()   
GitHub.VisualStudio.dll!GitHub.VisualStudio.Base.TeamExplorerServiceHolder.ActiveRepo.set(Microsoft.VisualStudio.TeamFoundation.Git.Extensibility.IGitRepositoryInfo value) 
GitHub.VisualStudio.dll!GitHub.VisualStudio.Base.TeamExplorerServiceHolder.CheckAndUpdate.AnonymousMethod__2(object r)  

It’s ultimately throwing a UriFormatException.

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Oct 8, 2015

Collaborator

Thanks for the report!

Collaborator

shana commented Oct 8, 2015

Thanks for the report!

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Oct 8, 2015

Collaborator

The fix for this has been included in release v1.0.15.2 which is available on the releases section, from the website and from the VS gallery. Thanks again for the catch!

Collaborator

shana commented Oct 8, 2015

The fix for this has been included in release v1.0.15.2 which is available on the releases section, from the website and from the VS gallery. Thanks again for the catch!

@rcorre

This comment has been minimized.

Show comment
Hide comment
@rcorre

rcorre Oct 8, 2015

Thanks! Just verified that it works on the new release.

rcorre commented Oct 8, 2015

Thanks! Just verified that it works on the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment