New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't comment on PR diff at specific comment when there are local changes #1227

Closed
grokys opened this Issue Sep 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@grokys
Contributor

grokys commented Sep 14, 2017

When one opens a diff from the PR details view by double-clicking and there are local changes in the working directory, the "You must commit and push your changes" message is shown, even though the diff that is shown is at a fixed commit, and has nothing to do with the working copy state.

Steps to repro:

  • Check out a PR branch
  • Make a change to a file, but don't commit it
  • "Compare Changes" on a file
  • Try to add a new comment
  • See that it says that you must commit your changes, even when the file state in the diff view represents an already committed state

image

This is because there is some incorrect logic in the PullRequestSession where the working directory state is checked even if the diff is at a fixed commit.

@grokys

This comment has been minimized.

Contributor

grokys commented Sep 14, 2017

Fixed by #1219

@grokys grokys closed this Sep 14, 2017

@meaghanlewis meaghanlewis modified the milestone: 2.3.4.40 Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment